Skip to content

(not sure) Remove items from any IF-inventory #825

@goncalodelima

Description

@goncalodelima

Is there an existing issue for this?

  • I have searched the existing issues

🐛 Describe the bug

This is just an assumption; I'm not sure if it's really this way, but I think it's important to report because I believe it is.

I noticed that in the latest version (3.7.1), if I'm in an IF-inventory and I do render.closeForPlayer() and then render.openForPlayer(AnotherInventory.class) on an item click, for example, I can remove items from AnotherInventory and the menu doesn't work. I imagine this happens because closeForPlayer closes on a future tick, not the current tick. If this is the case, then there's a very serious problem: Okay, I'm in inventory X, and the player clicks on an item that closes it (render.closeForPlayer() executed). Then the player quickly types a command that opens inventory Y, and if the player's executed command is interpreted by the server quickly enough, then it will be possible to remove any item from inventory Y.

✔️ Expected behavior

No response

👣 Steps to Reproduce

No response

💻 Platform

  • Bukkit
  • Sponge
  • Other

⭐ Server Version

1.8.8

📚 Library Version

3.7.1

✍️ Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions