-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#420: Create Windows Installer with WixToolset #978
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 13548740329Details
💛 - Coveralls |
This comment was marked as outdated.
This comment was marked as outdated.
build-msi/IDEASY.wxs
Outdated
<?define version = "1.0.0"?> | ||
<?define publisher = "devonfw-ide"?> | ||
<?define guid = "ba3ad5c0-94e9-42c3-9374-efaaddd3b967"?> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also define the correct meta information for the MSI packages
…#420-create-win-installer
But as I understand it, in the current workflow, we build the native image and include it in the deployment for the release. In the MSI build itself, we also need the whole package, including the binary |
Is added but has to be tested when #1084 is merged. |
@@ -52,10 +73,9 @@ jobs: | |||
- name: Download natives and build project | |||
uses: actions/download-artifact@v4 | |||
with: | |||
pattern: natives-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the pattern key here, because we use all uploaded artifacts anyway. Since we also include the msi artifact, we would have to check how to extend the pattern here in the case, we want to stick with it.
@@ -34,6 +34,27 @@ jobs: | |||
with: | |||
name: natives-${{ matrix.os }} | |||
path: cli/target/ideasy* | |||
- name: Build MSI with WixToolSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to integrate the whole MSI installation into maven, but the plugins are not compatbile with the latest version 5. https://wix-maven.github.io/wix-maven-plugin/
So I chose this place to insert the Wixtoolset installation. I would also be possible to move this to the last deploy
job, but there we are using ubuntu
as a runner and dotnet
would not work properly.
I think we could also move the whole thing into a separate Github Action. But maybe, we could create a new issue for that.
If you have any suggestions, than please comment on this
path: ./cli/target/ | ||
- name: Deploy to OSSRH nexus | ||
env: | ||
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
run: mvn --settings .mvn/settings.xml -DskipTests=true -Darchetype.test.skip=true -Dgpg.skip=true -Dstyle.color=always -B -ntp -Passembly,deploy deploy | ||
run: mvn --settings .mvn/settings.xml -DskipTests=true -Darchetype.test.skip=true -Dgpg.skip=true -Dstyle.color=always -B -ntp -Passembly,msi,deploy deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the MSI is attached into the deployment. I haven't change the release
workflow yet. Maybe we can first run the Nightly Build and then adapt the changes to the release workflow
https://github.com/alfeilex/IDEasy/actions/runs/13546792586/job/37860853837#step:5:1240
…/alfeilex/IDEasy into devonfw#420-create-win-installer
<configuration> | ||
<artifacts> | ||
<artifact> | ||
<file>${project.basedir}/target/${project.artifactId}-${revision}.msi</file> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, its named ide-cli-2025.02.002-beta.msi
If you change the name or the artifact-id,
then you have also to change line 279 because I rename the downloaded ideasy.msi
there
Fixes: #420
This PR implements the creation of a MSI file for Windows Installer with WixToolset
It includes:
C:\projects
) or customizeideasy.exe -f install
Nightly Build
andRelease
workflow