Refactoring to use locals instead of null

Author: snemetz

main.tf

@@ -5,7 +5,19 @@
 #   Add attributes to name if not empty
 #   return name as lowercase
 #   return id and id_20, id_32 for combined name
+#   Refactor to use local and output the locals. Test - test - test
 
+locals {
+  attr      = "${lower(format("%s", join(var.delimiter, compact(var.attributes))))}"
+  env       = "${lower(format("%s", var.environment))}"
+  name_low  = "${lower(format("%s", var.name))}"
+  org       = "${lower(format("%s", var.organization))}"
+  name_env  = "${var.namespace-env ? join(var.delimiter, list(local.env, local.name_low)) : local.name_low}"
+  name_org  = "${var.namespace-org ? join(var.delimiter, list(local.org, local.name_env)) : local.name_env}"
+  name_20   = "${substr(replace(local.name_org,"_","-"),0,19 <= length(local.name_org) ? 19 : length(local.name_org))}"
+  name_32   = "${substr(replace(local.name_org,"_","-"),0,31 <= length(local.name_org) ? 31 : length(local.name_org))}"
+}
+/*
 resource "null_resource" "pre1" {
   count     = "${var.enabled ? 1 : 0}"
   triggers  = {
@@ -32,6 +44,7 @@ resource "null_resource" "this" {
   triggers  = {
     attributes    = "${null_resource.pre1.triggers.attributes}"
     environment   = "${null_resource.pre1.triggers.environment}"
+    id            = "${local.name_org}"
     organization  = "${null_resource.pre1.triggers.organization}"
     name          = "${null_resource.pre3.triggers.name_org}"
     name_20       = "${substr(replace(null_resource.pre3.triggers.name_org,"_","-"),0,19 <= length(null_resource.pre3.triggers.name_org) ? 19 : length(null_resource.pre3.triggers.name_org))}"
@@ -42,5 +55,6 @@ resource "null_resource" "this" {
       map("Name", var.name),
       map("Environment", var.environment),
       map("Terraform", "true") )}"*/
-  }
+/*  }
 }
+*/

outputs.tf

@@ -1,4 +1,35 @@
 
+output "attributes" {
+  description = "Attribute string lowercase"
+  value       = "${local.attr}"
+}
+output "environment" {
+  description = "Environment name lowercase"
+  value       = "${local.env}"
+}
+output "id" {
+  description = "Full formatted name ID"
+  #value       = "${null_resource.this.triggers.id}"
+  value       = "${local.name_org}"
+}
+output "name" {
+  description = "Name"
+  value       = "${local.name_low}"
+}
+output "name_20" {
+  description = "Name truncated to 20 characters"
+  value       = "${local.name_20}"
+}
+output "name_32" {
+  description = "Name truncated to 32 characters"
+  value       = "${local.name_32}"
+}
+output "organization" {
+  description = "Organization name lowercase"
+  value       = "${local.org}"
+}
+
+/*
 output "attributes" {
   description = "Attribute string lowercase"
   value       = "${null_resource.this.triggers.attributes}"
@@ -7,6 +38,11 @@ output "environment" {
   description = "Environment name lowercase"
   value       = "${null_resource.this.triggers.environment}"
 }
+output "id" {
+  description = "Full formatted name ID"
+  #value       = "${null_resource.this.triggers.id}"
+  value       = "${local.name_org}=new"
+}
 output "name" {
   description = "Name"
   value       = "${null_resource.this.triggers.name}"
@@ -23,13 +59,14 @@ output "organization" {
   description = "Organization name lowercase"
   value       = "${null_resource.this.triggers.organization}"
 }
+*/
 output "tags" {
   value = "${ merge(
     var.tags,
     map(
-      "Name", "${null_resource.this.triggers.name}",
-      "Environment", "${null_resource.this.triggers.environment}",
-      "Organization", "${null_resource.this.triggers.organization}",
+      "Name", "${local.name_org}",
+      "Environment", "${local.env}",
+      "Organization", "${local.org}",
       "Terraform", "true"
     ))}"
 }

test/outputs.tf

@@ -7,6 +7,9 @@ output "environment" {
   description = "Environment name lowercase"
   value       = "${module.labels.environment}"
 }
+output "id" {
+  value       = "${module.labels.id}"
+}
 output "name" {
   description = "Name"
   value       = "${module.labels.name}"

variables.tf

@@ -37,6 +37,9 @@ variable "tags" {
 }
 
 // Internal Variables
+variable "id" {
+  default = ""
+}
 variable "name_lower" {
   description = "Internal"
   default     = ""
@@ -49,3 +52,7 @@ variable "name_org" {
   description = "Internal"
   default     = ""
 }
+variable "nameo" {
+  description = "Internal"
+  default     = ""
+}