Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets vs primary configuration.yml #47

Open
theoiorga opened this issue Jul 5, 2018 · 4 comments
Open

Assets vs primary configuration.yml #47

theoiorga opened this issue Jul 5, 2018 · 4 comments
Assignees

Comments

@theoiorga
Copy link

Considering configuration.yml file, I understand that primary is the pages directory in which you create each slide, but what about the assets, where do we create those PI and patient brochure?

Thanks

@stevebritton
Copy link
Member

Hey @theoiorga,

For global assets, everything that is placed in the following global folder and then is included in every Key Message (Pages) folder during the build process.

Example of global folder
https://github.com/devopsgroup-io/veeva/tree/master/examples/clm/app/templates/pages/global

Please note that this build process pre-dated the option of Shared assets in Veeva, so version 2.0 of this module will have a new way of dealing with shared assets.

Please let me know if this helps.

-Steve

@stevebritton stevebritton self-assigned this Jul 5, 2018
@theoiorga
Copy link
Author

theoiorga commented Jul 6, 2018

@stevebritton , Thank you for the quick response.
This means that if I want Full PI to work I should create an hbs inside that global folder? Now if I click it, I have a "get" error.
Also, those arrows shouldn't they be active only on slides that contain subslides? Because as it is right now, after I upload them to the app, those arrows act like they are going to a subslide, same goes for the short slide action. The long slide action navigates correctly.

When should we expect the 2.0 version?

Thank you so much for your time,
Theo

@stevebritton
Copy link
Member

Actually, you don't need a .hbs file, you can simply place a pdf in the global folder and reference it like so:

{{root}}global/full_pi.pdf

Also, here's an example of a page referencing global assets:
https://github.com/devopsgroup-io/veeva/blob/master/examples/clm/app/templates/layouts/default.hbs

Regarding the arrows, the current .js library is programmed to slide through sub slides as well as primary slides (key messages) in a linear fashion. With this functionality in place, I would also disable the Swipe feature in SalesForce as that will ensure the arrows and .js library can handle all of the swipe actions without iRep overriding the gesture.

For version 2.0, we don't have any hard set dates nailed down; however, I'll be sure to ping you once it's "production ready".

-Steve

@theoiorga
Copy link
Author

@stevebritton and where would I need to reference it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants