Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyvault] style: format to f-string samples/backup_restore_operations_async.py #33

Closed
wants to merge 1 commit into from

Conversation

KdHyeon0661
Copy link

@KdHyeon0661 KdHyeon0661 commented Jul 29, 2022

Modified azure-sdk-for-python/sdk/keyvault/azure-keyvault-keys/samples/key_rotation.py

Updated f-string formatting

Close #18

Before:
print("Key with name '{0}' created with key type '{1}'".format(key.name, key.key_type))

After:
print(f"Key with name '{key.name}' created with key type '{key.key_type}'")

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ianychoi
Copy link
Member

Would you help more precisely describe your commit message? Thanks!

@KdHyeon0661 KdHyeon0661 closed this by deleting the head repository Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

f-stirng modify sample/backup_restore_operations_async.py
2 participants