Skip to content

Commit 65b15e8

Browse files
authored
Fix unassignedShards metric and rename singletons metric tag (#123)
* Fix metrics * Change order
1 parent 309010c commit 65b15e8

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

entities/src/main/scala/com/devsisters/shardcake/Sharding.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ class Sharding private (
6868
ZIO.foreach(singletons) {
6969
case (name, run, None) =>
7070
ZIO.logDebug(s"Starting singleton $name") *>
71-
Metrics.singletons.tagged("name", name).increment *>
71+
Metrics.singletons.tagged("singleton_name", name).increment *>
7272
run.forkDaemon.map(fiber => (name, run, Some(fiber)))
7373
case other => ZIO.succeed(other)
7474
}
@@ -83,7 +83,7 @@ class Sharding private (
8383
ZIO.foreach(singletons) {
8484
case (name, run, Some(fiber)) =>
8585
ZIO.logDebug(s"Stopping singleton $name") *>
86-
Metrics.singletons.tagged("name", name).decrement *>
86+
Metrics.singletons.tagged("singleton_name", name).decrement *>
8787
fiber.interrupt.as((name, run, None))
8888
case other => ZIO.succeed(other)
8989
}

manager/src/main/scala/com/devsisters/shardcake/ShardManager.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ class ShardManager(
7676
)
7777
}
7878
_ <- ManagerMetrics.pods.decrement
79+
_ <- ManagerMetrics.unassignedShards.incrementBy(unassignments.size)
7980
_ <- eventsHub.publish(ShardingEvent.PodUnregistered(podAddress))
8081
_ <- eventsHub
8182
.publish(ShardingEvent.ShardsUnassigned(podAddress, unassignments))

0 commit comments

Comments
 (0)