Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Move CRA project to Next.js #351

Open
devvsakib opened this issue Apr 6, 2023 · 25 comments
Open

[FEAT]: Move CRA project to Next.js #351

devvsakib opened this issue Apr 6, 2023 · 25 comments
Labels
enhancement New feature or request [priority: high] as fast as possible

Comments

@devvsakib
Copy link
Owner

devvsakib commented Apr 6, 2023

Is your feature request related to a problem? Please describe.
Currently, our project is built with Create React App (CRA). However, we would like to migrate the project to Next.js in order to take advantage of its benefits such as server-side rendering, automatic code splitting, and simplified routing.

This issue will involve the following tasks:

  1. Setting up a Next.js project and copying over the existing code
  2. Adjusting the code to work with Next.js (e.g. changing import/export statements, modifying the file structure)
  3. Testing the new Next.js project to ensure it is functioning correctly and no major issues have been introduced

Describe alternatives you've considered
If something bad happens, we will abort the migration.

@devvsakib devvsakib added enhancement New feature or request [priority: high] as fast as possible labels Apr 6, 2023
@devvsakib devvsakib self-assigned this Apr 6, 2023
@ghost
Copy link

ghost commented Apr 8, 2023

Hi!I hope you are doing well i will convert React frontend to Next js plz assign this issue to me

@devvsakib devvsakib assigned ghost Apr 8, 2023
@devvsakib
Copy link
Owner Author

Assigned @moizsheraz .
Good Luck and be careful

@devvsakib devvsakib removed their assignment Apr 8, 2023
@ghost
Copy link

ghost commented Apr 8, 2023

Any deadline to complete it?

@devvsakib
Copy link
Owner Author

devvsakib commented Apr 8, 2023

CRA is dead, so it will be better if we move to nextjs as fast as possible, What deadline do you expect?

@ghost
Copy link

ghost commented Apr 8, 2023

what do you expect form a contributor?

@devvsakib
Copy link
Owner Author

not too late, not too fast. Max 2/3 days will be enough if I'm not wrong.

@ghost
Copy link

ghost commented Apr 8, 2023

Done!

@ghost
Copy link

ghost commented Apr 9, 2023

Hi! Whole Project has been converted to Next js but I am getting one error can you help me out?

@devvsakib
Copy link
Owner Author

Sure, Could you please share the error message with me so I can better understand the issue?

@ghost
Copy link

ghost commented Apr 9, 2023

htmlToImage.toPng(template,{ find: (node) => (node.tagName !== 'i') })
.then(dataUrl => {
setContributorCard(dataUrl);
})

In the contributer card generation image is not appearing also generate card button is not working

@devvsakib
Copy link
Owner Author

Kindly share "Error Message"

@ghost
Copy link

ghost commented Apr 9, 2023

Bro the Project has been whole converted to Next js but there are one or two errors . Should i make PR?

@ghost
Copy link

ghost commented Apr 9, 2023

there are no major issues just one or two issues

@devvsakib
Copy link
Owner Author

Is it causing any major error? or it has no effect on the website @moizsheraz? If it's not, you can submit PR

@ghost
Copy link

ghost commented Apr 9, 2023

No, no major issue and I want some help form you regarding PR

@devvsakib
Copy link
Owner Author

Sure, submit PR

@ghost
Copy link

ghost commented Apr 9, 2023

i have convert all the project by making new next js project now i make PR if you guide i will be Thankful

@ghost
Copy link

ghost commented Apr 9, 2023

should i move the converted project folder inside cloned project? I am new to open source.

@devvsakib
Copy link
Owner Author

Sorry for that, I didn't understand what did you mean by that

@ghost
Copy link

ghost commented Apr 9, 2023

I have convert your Project by creating new next app and now i want to make PR how i make PR ?

@devvsakib
Copy link
Owner Author

push all code to your cloned repository, then you will see a message to open pull request

@ghost
Copy link

ghost commented Apr 9, 2023

ok

@devvsakib
Copy link
Owner Author

devvsakib commented Apr 9, 2023

  • Open Terminal in your project folder
  • git add .
  • git commit -m "yourmessage"
  • git push
  • go to forked repository

image

image

Done

@ghost
Copy link

ghost commented Apr 9, 2023

okay

@ghost
Copy link

ghost commented Apr 9, 2023

Done plz check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request [priority: high] as fast as possible
Projects
None yet
Development

No branches or pull requests

1 participant