From f129ec6bd79115d512889044031558ebfb564377 Mon Sep 17 00:00:00 2001
From: Adam Spofford <adam.spofford@dfinity.org>
Date: Wed, 11 Dec 2024 04:57:21 -0800
Subject: [PATCH] Add command to refresh following

---
 CHANGELOG.md                                    |  2 ++
 src/commands/neuron_manage.rs                   | 17 ++++++++++++++++-
 .../default/neuron_manage/refresh_followers.txt | 15 +++++++++++++++
 tests/output/neuron_manage.rs                   |  6 ++++++
 4 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 tests/output/default/neuron_manage/refresh_followers.txt

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a0caae6..cb82f4f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+- Added `quill neuron-manage --refresh-followers`.
+
 ## [0.5.2] - 2024-12-05
 
 - Fixed the display format of SNS sale tickets.
diff --git a/src/commands/neuron_manage.rs b/src/commands/neuron_manage.rs
index ba8d21c..ddc67cf 100644
--- a/src/commands/neuron_manage.rs
+++ b/src/commands/neuron_manage.rs
@@ -9,6 +9,7 @@ use candid::{CandidType, Encode, Principal};
 use clap::{Parser, ValueEnum};
 use ic_base_types::PrincipalId;
 use ic_nns_common::pb::v1::{NeuronId, ProposalId};
+use ic_nns_governance::pb::v1::manage_neuron::RefreshVotingPower;
 use ic_nns_governance::pb::v1::{
     manage_neuron::{
         configure::Operation, disburse::Amount, AddHotKey, ChangeAutoStakeMaturity, Command,
@@ -138,6 +139,11 @@ pub struct ManageOpts {
     /// a limited subset (Private).
     #[arg(long)]
     set_visibility: Option<NativeVisibility>,
+
+    /// Refresh the neuron's voting power by reaffirming the current list of followers.
+    /// This must be done every so often to avoid neurons diminishing in voting power.
+    #[arg(long)]
+    refresh_followers: bool,
 }
 
 #[derive(Debug, Clone, Copy, PartialEq, Eq, ValueEnum)]
@@ -152,7 +158,7 @@ pub fn exec(auth: &AuthInfo, opts: ManageOpts) -> AnyhowResult<Vec<IngressWithRe
             opts.add_hot_key.is_none() && opts.remove_hot_key.is_none() && !opts.disburse && opts.disburse_amount.is_none() && opts.disburse_to.is_none()
             && !opts.clear_manage_neuron_followees && !opts.join_community_fund && !opts.leave_community_fund
             && opts.follow_topic.is_none() && opts.follow_neurons.is_none() && opts.register_vote.is_none() && !opts.reject
-            && opts.set_visibility.is_none(),
+            && opts.set_visibility.is_none() && !opts.refresh_followers,
             "\
 Cannot use --ledger with these flags. This version of quill only supports the following neuron-manage operations with a Ledger device:
 --additional-dissolve-delay-seconds, --start-dissolving, --stop-dissolving, --split, --merge-from-neuron, --spawn, --stake-maturity, --auto-stake-maturity"
@@ -416,6 +422,15 @@ Cannot use --ledger with these flags. This version of quill only supports the fo
         msgs.push(args);
     }
 
+    if opts.refresh_followers {
+        let args = Encode!(&ManageNeuron {
+            command: Some(Command::RefreshVotingPower(RefreshVotingPower {})),
+            neuron_id_or_subaccount: id.clone(),
+            id: None,
+        })?;
+        msgs.push(args);
+    }
+
     if msgs.is_empty() {
         return Err(anyhow!("No instructions provided"));
     }
diff --git a/tests/output/default/neuron_manage/refresh_followers.txt b/tests/output/default/neuron_manage/refresh_followers.txt
new file mode 100644
index 0000000..59c939c
--- /dev/null
+++ b/tests/output/default/neuron_manage/refresh_followers.txt
@@ -0,0 +1,15 @@
+Sending message with
+
+  Call type:   update
+  Sender:      fdsgv-62ihb-nbiqv-xgic5-iefsv-3cscz-tmbzv-63qd5-vh43v-dqfrt-pae
+  Canister id: rrkah-fqaaa-aaaaa-aaaaq-cai
+  Method name: manage_neuron
+  Arguments:   (
+  record {
+    id = null;
+    command = opt variant { RefreshVotingPower = record {} };
+    neuron_id_or_subaccount = opt variant {
+      NeuronId = record { id = 2_313_380_519_530_470_538 : nat64 }
+    };
+  },
+)
diff --git a/tests/output/neuron_manage.rs b/tests/output/neuron_manage.rs
index 013e6dc..68ccb06 100644
--- a/tests/output/neuron_manage.rs
+++ b/tests/output/neuron_manage.rs
@@ -120,3 +120,9 @@ fn set_visibility() {
     ))
     .diff("neuron_manage/set_visibility.txt")
 }
+
+#[test]
+fn refresh_followers() {
+    quill_send(&format!("neuron-manage {NEURON_ID} --refresh-followers"))
+        .diff("neuron_manage/refresh_followers.txt")
+}