Test on windows

Author: dflook

test/test_utf8_encoding.py

@@ -3,6 +3,7 @@
 import python_minifier
 import tempfile
 import os
+import codecs
 
 
 def test_minify_utf8_file():
@@ -44,13 +45,15 @@ def arrow_symbols():
 '''
 
     # Write to temporary file with UTF-8 encoding
-    with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False, encoding='utf-8') as f:
-        f.write(source_code)
+    # Python 2.7 doesn't support encoding parameter, so use binary mode
+    with tempfile.NamedTemporaryFile(mode='wb', suffix='.py', delete=False) as f:
+        f.write(source_code.encode('utf-8'))
         temp_file = f.name
 
     try:
         # Read the file and minify it
-        with open(temp_file, 'r', encoding='utf-8') as f:
+        # Python 2.7 doesn't support encoding parameter in open()
+        with codecs.open(temp_file, 'r', encoding='utf-8') as f:
             original_content = f.read()
 
         # This should work - minify the UTF-8 content

test/test_windows_encoding_regression.py

@@ -5,6 +5,34 @@
 import subprocess
 import sys
 import locale
+import codecs
+
+# Compatibility for subprocess.run (added in Python 3.5)
+def run_subprocess(cmd, timeout=None):
+    """Cross-platform subprocess runner for Python 2.7+ compatibility."""
+    if hasattr(subprocess, 'run'):
+        # Python 3.5+
+        return subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, timeout=timeout)
+    else:
+        # Python 2.7, 3.3, 3.4
+        popen = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+        stdout, stderr = popen.communicate()
+        # Create a simple result object similar to subprocess.CompletedProcess
+        class Result:
+            def __init__(self, returncode, stdout, stderr):
+                self.returncode = returncode
+                self.stdout = stdout
+                self.stderr = stderr
+        return Result(popen.returncode, stdout, stderr)
+
+def safe_decode(data, encoding='utf-8', errors='replace'):
+    """Safe decode for Python 2.7/3.x compatibility."""
+    if isinstance(data, bytes):
+        try:
+            return data.decode(encoding, errors)
+        except UnicodeDecodeError:
+            return data.decode(encoding, 'replace')
+    return data
 
 
 def test_cli_output_flag_with_unicode():
@@ -17,8 +45,9 @@ def test_cli_output_flag_with_unicode():
     source_code = 'print("❌ ✓ 🐍 Привет © ∀")'
 
     # Create temporary source file
-    with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False, encoding='utf-8') as source_file:
-        source_file.write(source_code)
+    # Python 2.7 doesn't support encoding parameter, so use binary mode
+    with tempfile.NamedTemporaryFile(mode='wb', suffix='.py', delete=False) as source_file:
+        source_file.write(source_code.encode('utf-8'))
         source_path = source_file.name
 
     # Create temporary output file path
@@ -30,16 +59,17 @@ def test_cli_output_flag_with_unicode():
         os.unlink(output_path)
 
         # Run pyminify CLI with --output flag (this should reproduce Windows encoding errors)
-        result = subprocess.run([
+        result = run_subprocess([
             sys.executable, '-m', 'python_minifier',
             source_path, '--output', output_path
-        ], stdout=subprocess.PIPE, stderr=subprocess.PIPE, timeout=30)
+        ], timeout=30)
 
         # Test should fail if CLI command fails (indicates Windows encoding bug)
-        assert result.returncode == 0, "CLI failed with encoding error: {}".format(result.stderr)
+        assert result.returncode == 0, "CLI failed with encoding error: {}".format(safe_decode(result.stderr))
 
         # Verify the output file was created and contains Unicode characters
-        with open(output_path, 'r', encoding='utf-8') as f:
+        # Python 2.7 doesn't support encoding parameter in open()
+        with codecs.open(output_path, 'r', encoding='utf-8') as f:
             minified_content = f.read()
 
         # Verify problematic Unicode characters are preserved
@@ -66,22 +96,24 @@ def test_cli_in_place_with_unicode():
     source_code = 'print("❌ ✓ 🐍 Привет © ∀")'
 
     # Create temporary file
-    with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False, encoding='utf-8') as temp_file:
-        temp_file.write(source_code)
+    # Python 2.7 doesn't support encoding parameter, so use binary mode
+    with tempfile.NamedTemporaryFile(mode='wb', suffix='.py', delete=False) as temp_file:
+        temp_file.write(source_code.encode('utf-8'))
         temp_path = temp_file.name
 
     try:
         # Run pyminify with --in-place flag
-        result = subprocess.run([
+        result = run_subprocess([
             sys.executable, '-m', 'python_minifier',
             temp_path, '--in-place'
-        ], stdout=subprocess.PIPE, stderr=subprocess.PIPE, timeout=30)
+        ], timeout=30)
 
         # Test should fail if CLI command fails (indicates Windows encoding bug)
-        assert result.returncode == 0, "CLI failed with encoding error: {}".format(result.stderr)
+        assert result.returncode == 0, "CLI failed with encoding error: {}".format(safe_decode(result.stderr))
 
         # Verify Unicode characters are preserved in the modified file
-        with open(temp_path, 'r', encoding='utf-8') as f:
+        # Python 2.7 doesn't support encoding parameter in open()
+        with codecs.open(temp_path, 'r', encoding='utf-8') as f:
             content = f.read()
 
         assert "✓" in content
@@ -103,22 +135,23 @@ def test_cli_stdout_with_unicode():
     """
     source_code = 'print("❌ ✓ 🐍 Привет © ∀")'
 
-    with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False, encoding='utf-8') as temp_file:
-        temp_file.write(source_code)
+    # Python 2.7 doesn't support encoding parameter, so use binary mode
+    with tempfile.NamedTemporaryFile(mode='wb', suffix='.py', delete=False) as temp_file:
+        temp_file.write(source_code.encode('utf-8'))
         temp_path = temp_file.name
 
     try:
         # Run without --output or --in-place (should output to stdout)
-        # Use stdout=PIPE, stderr=PIPE to avoid subprocess decoding issues with Windows
+        # Use our compatibility function to avoid subprocess decoding issues with Windows
         # We'll manually decode as UTF-8 to properly handle Unicode characters
-        result = subprocess.run([
+        result = run_subprocess([
             sys.executable, '-m', 'python_minifier', temp_path
-        ], stdout=subprocess.PIPE, stderr=subprocess.PIPE, timeout=30)
+        ], timeout=30)
 
-        assert result.returncode == 0, "Stdout output failed: {}".format(result.stderr.decode('utf-8', errors='replace'))
+        assert result.returncode == 0, "Stdout output failed: {}".format(safe_decode(result.stderr))
 
         # Decode stdout and verify Unicode characters are present
-        stdout_text = result.stdout.decode('utf-8', errors='replace')
+        stdout_text = safe_decode(result.stdout)
         assert "❌" in stdout_text
         assert "✓" in stdout_text
         assert "🐍" in stdout_text