Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Working/Changing #33

Closed
nmsmith22389 opened this issue Oct 4, 2017 · 7 comments
Closed

Not Working/Changing #33

nmsmith22389 opened this issue Oct 4, 2017 · 7 comments

Comments

@nmsmith22389
Copy link

I tried on stable and canary. The initial default icon pops up but it never changes.

macOS High Sierra

@dfrankland
Copy link
Owner

Are you using bash?

@sangdth
Copy link

sangdth commented Oct 5, 2017

I have same issue, the first icon shows up but never change, even when I use mapIcons.

And when I echo bash, it showed /usr/local/bin/bash, should I do anything extra to get it works?

Thanks.

@RoyHP
Copy link

RoyHP commented Oct 11, 2017

Is this not expected to work in zsh? (because it doesn't for me) - icon also stays as the terminal icon. Using zsh on high sierra with node 8.

@sangdth
Copy link

sangdth commented Oct 11, 2017

I don't know why, but I added this block into bash_profile, and it works!

vercel/hyper#1188 (comment)

If I could have some explaination, it would be great as I'm still learning programming. I don't want just copy/paste. Thanks for your time, much appreciate.

@dfrankland
Copy link
Owner

@RoyHP & @sangdth - Bash and Zsh do not change the title out of the box. You must configure them to actually change the title. hyper-tab-icons will change the icon depending on the text of the title. If you check the link that @sangdth added (vercel/hyper#1188 (comment)), it's a thread on hyper about how to set the title.

@sangdth
Copy link

sangdth commented Oct 12, 2017

Thank you @dfrankland !

@bmrobin
Copy link

bmrobin commented May 2, 2018

@sangdth confirmed, that bash_profile worked for me as well. i think this issue can be marked as resolved since there is a work-around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants