Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includeScript() and inlineStyle() of external resources #61

Open
dgp1130 opened this issue Feb 14, 2023 · 0 comments
Open

includeScript() and inlineStyle() of external resources #61

dgp1130 opened this issue Feb 14, 2023 · 0 comments
Labels
feature New feature or request

Comments

@dgp1130
Copy link
Owner

dgp1130 commented Feb 14, 2023

Currently includeScript() and inlineStyle() do not have well defined semantics for importing files outside the current workspace. We should define exactly what syntax they should use and how those dependencies should be specified.

ts_project() / js_library() can support external dependencies as long as they are wrapped in an NPM package, and then they are importable by the package name. We could consider extending those semantics for css_library() dependencies and prerender_component() dependencies.

@dgp1130 dgp1130 added the feature New feature or request label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant