Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle multiple prerender_pages_unbundled() #72

Open
dgp1130 opened this issue Mar 18, 2023 · 0 comments
Open

Bundle multiple prerender_pages_unbundled() #72

dgp1130 opened this issue Mar 18, 2023 · 0 comments
Labels
feature New feature or request

Comments

@dgp1130
Copy link
Owner

dgp1130 commented Mar 18, 2023

I've used multiple prerender_pages() targets to build different pages independently and merge them together with web_resources(). However this isn't ideal, because each prerender_pages() target bundles all its JavaScript independently. This means any shared chunks between multiple prerender_pages() targets won't actually be shared at runtime.

prerender_pages_unbundled() skips the work which should be skipped, but I don't have a good way to run that work later. Maybe we should have a bundle_site() rule which takes multiple prerender_pages_unbundled(), bundles the JavaScript and injects the resources.

@dgp1130 dgp1130 added the feature New feature or request label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant