Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't notify if a URL if it is inaccessible #2657

Closed
profucius opened this issue Sep 24, 2024 · 1 comment
Closed

Doesn't notify if a URL if it is inaccessible #2657

profucius opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels

Comments

@profucius
Copy link

profucius commented Sep 24, 2024

Describe the bug
I am using ChangeDetection to watch if a website is online or not, so that I can perform maintenance if it goes offline. This is a local site, not public. ChangeDetection successfully has access to the URL when the page is online, however when the page is offline (due to the docker container that hosts that page is offline), ChangeDetection provides an Exception and then does not notify me using the saved and tested notification method.

Exception: HTTPConnectionPool(host='browser-chrome', port=4444): 
Max retries exceeded with url: /wd/hub/session 
(Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7e1deeb39d10>: 
Failed to establish a new connection: [Errno -2] Name or service not known'))

Version
v0.46.04

To Reproduce

Steps to reproduce the behavior:

  1. Watch a localhost URL that is accessible, then take that page down and Recheck in CD.
    1b. If that's not possible, watch a website that does not exist, for instance: http://doesnotexist.com. I believe this will suffice as providing the same test environment.
  2. Notice that the notifications do not send to a destination.

Expected behavior
I believe ChangeDetection should send a notification when the page cannot be accessed. If this is not yet a feature, then it should be added, as this is a valid need for an app that detections changes.

Desktop (please complete the following information):

  • OS: Docker container
  • Browser: Basic Plaintext/HTTP client
@dgtlmoon
Copy link
Owner

reads like duplicate of PR in progess #1945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants