From b05581b6a90aff6c8eae38912abf38b59dbcedf3 Mon Sep 17 00:00:00 2001 From: HendrikThePendric Date: Wed, 16 Oct 2024 15:51:14 +0200 Subject: [PATCH] chore: adjust comments for clarity --- .../customSVGOptions/singleValue/renderer/addIconElement.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js b/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js index 6c3514a4a..b1df849f8 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js +++ b/src/visualizations/config/adapters/dhis_highcharts/customSVGOptions/singleValue/renderer/addIconElement.js @@ -18,10 +18,11 @@ export function addIconElement(svgString, color) { /* The code below makes some assumptions about icon SVGs: * 1. The SVG children are all elements and they are not nested - * 2. On the `d`, `fill-rule`, `clip-rule` and `fill` attributes are used */ + * 2. Only the `d`, `fill-rule`, `clip-rule` and `fill` attributes are used */ Array.from(svgIconDocument.documentElement.children).forEach((pathNode) => { /* Highcharts expects an array of letters and numbers but the - * d-attribute string does not put space in between them. */ + * d-attribute string only puts spaces in between adjacent number, + * not between letter and numbers. */ const d = pathNode .getAttribute('d') // Add space after letter when followed by number