From dd14a9460be4374f6ddefbd670979a041083becf Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Fri, 27 Sep 2024 14:34:08 +0200 Subject: [PATCH 1/5] chore: add console.log to see whats going on --- src/visualizations/config/adapters/dhis_highcharts/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/visualizations/config/adapters/dhis_highcharts/index.js b/src/visualizations/config/adapters/dhis_highcharts/index.js index 29ecf41c0..e7a4bb035 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/index.js +++ b/src/visualizations/config/adapters/dhis_highcharts/index.js @@ -163,6 +163,8 @@ export default function ({ store, layout, el, extraConfig, extraOptions }) { }) } + console.log('jj config.plotOptions', config.plotOptions) + // hide empty categories if (_layout.hideEmptyRowItems !== 'NONE') { config = getTrimmedConfig(config, _layout) From f96237f06a0e791c3432aaef3e2dd23a26a7dbd0 Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Fri, 27 Sep 2024 15:43:43 +0200 Subject: [PATCH 2/5] chore: try disabling the inactive state changes --- .../config/adapters/dhis_highcharts/plotOptions.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js index 928019506..aa2d91002 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js +++ b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js @@ -68,6 +68,11 @@ export default ({ point: { events: { click: function () { + console.log( + 'jj onClick handler', + this.category, + this.series.name + ) onClick(this.graphic?.element, { category: this.category, series: this.series.name, @@ -75,6 +80,10 @@ export default ({ }, }, }, + states: { + inactive: { + enabled: false, + }, }, } : {} From 4f10dcd953f1c1f226a2a7b406c77adbcac11219 Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Fri, 27 Sep 2024 16:00:14 +0200 Subject: [PATCH 3/5] chore: oops syntax error --- .../config/adapters/dhis_highcharts/plotOptions.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js index aa2d91002..c90ec47c3 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js +++ b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js @@ -84,6 +84,7 @@ export default ({ inactive: { enabled: false, }, + }, }, } : {} From 7b94c811ff50a245f6043c1ccbeb7c06463e5ffe Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Fri, 27 Sep 2024 19:18:50 +0200 Subject: [PATCH 4/5] chore: adjust the hover brightness to darken when hovering --- .../config/adapters/dhis_highcharts/plotOptions.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js index c90ec47c3..43605d12b 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js +++ b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js @@ -84,6 +84,9 @@ export default ({ inactive: { enabled: false, }, + hover: { + brightness: -0.3, // darken + }, }, }, } From d916af596798564e79999eed1470e1973c0fa349 Mon Sep 17 00:00:00 2001 From: Jen Jones Arnesen Date: Sat, 28 Sep 2024 09:07:19 +0200 Subject: [PATCH 5/5] chore: cleanup console.log --- src/visualizations/config/adapters/dhis_highcharts/index.js | 2 +- .../config/adapters/dhis_highcharts/plotOptions.js | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/visualizations/config/adapters/dhis_highcharts/index.js b/src/visualizations/config/adapters/dhis_highcharts/index.js index e7a4bb035..504a72b16 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/index.js +++ b/src/visualizations/config/adapters/dhis_highcharts/index.js @@ -163,7 +163,7 @@ export default function ({ store, layout, el, extraConfig, extraOptions }) { }) } - console.log('jj config.plotOptions', config.plotOptions) + console.log('config.plotOptions', config.plotOptions) // hide empty categories if (_layout.hideEmptyRowItems !== 'NONE') { diff --git a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js index 43605d12b..f6c45ba2f 100644 --- a/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js +++ b/src/visualizations/config/adapters/dhis_highcharts/plotOptions.js @@ -68,11 +68,6 @@ export default ({ point: { events: { click: function () { - console.log( - 'jj onClick handler', - this.category, - this.series.name - ) onClick(this.graphic?.element, { category: this.category, series: this.series.name,