-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix local jest run #3218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3218.data-visualizer.netlify.dhis2.org |
HendrikThePendric
changed the title
Chore/fix-local-jest-test-run
chore: fix local jest run
Sep 23, 2024
src/components/DimensionsPanel/Dialogs/AddToLayoutButton/__tests__/AddToLayoutButton.spec.js
Outdated
Show resolved
Hide resolved
jenniferarnesen
approved these changes
Sep 24, 2024
HendrikThePendric
added
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Sep 24, 2024
🎉 This PR is included in version 100.7.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to a JIRA issue, but the fact that it's currently impossible to run tests locally is highly problematic when trying to debug test failures after making changes in the codebase.
Key features
Description
The current state of the PR is captured in the TODO list
TODO
Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
).Not 100% sure how to fix this.I did end up finding a good fix for this in the endError: Uncaught [TypeError: axis is not iterable (cannot read property undefined)]
. This is caused byconvertOuLevelsToUids
which is imported from@dhis2/analytics
and is ultimately coming fromlayoutGetAllDimensions
, which doesn't handleaxis
being undefined. Not sure if the correct fix is to adjust the test data or the implementation in@dhis2/analytics