Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character don't exit when called, on 4.3 Web Exports #2384

Closed
metanoder opened this issue Sep 6, 2024 · 2 comments
Closed

Character don't exit when called, on 4.3 Web Exports #2384

metanoder opened this issue Sep 6, 2024 · 2 comments

Comments

@metanoder
Copy link
Contributor

metanoder commented Sep 6, 2024

The problem

Describe the bug

  • On only web export, during dialogic play through, execute function "characters leave"
  • ( ie.. leave character1 [animation="Instant Out"] )
  • No characters leave.

To Reproduce
Steps to reproduce the behavior:

  • Functioning godot + dialogic project.
  • Godot 4.3 web: threaded and single thread exports, on both prebuilt downloads and self compiled builds.
  • Bug present in both exports.

Expected behavior

  • Characters leave when called to.

Screenshots
If applicable, add screenshots to help explain your problem.

System (please complete the following information):

  • OS: Windows and Mac
  • Godot Version: Godot 4.3 prebuilt and compiled
  • Dialogic Version: 2.0 Alpha 15

Solutions

WIP

Workaround

Tried the different options for characters leaving.
Leave --All--
Leave Character 1
etc, nothing ran
image

Possible fixes

Any idea to fix the issue or a link to the line of code that might be the cause for this problem

This might be a Godot Web Export Templates issue... as it works on other exports. Will see if there's anything that can be done...

@Jowan-Spooner
Copy link
Collaborator

Hey @metanoder, thanks for the report. Could you check if #2391 fixes this for you? I confirmed that if fixes animations on a windows export and hoping it's the same issue.

@metanoder
Copy link
Contributor Author

metanoder commented Sep 12, 2024

Hi @Jowan-Spooner

Yes, that did it!
Tested on Godot 4.3 compiled single threaded and use the latest main dialogic build, and manually copy and pasted your fix.
<note: when clone and running from https://github.com/Jowan-Spooner/dialogic.git, dialogic for web export does not function...
jowan_branch
...>

Ran it on Edge, Chrome, Firefox, and Safari.
It works!

web_export_animation_test_43_compiled.mp4

thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants