Skip to content

Commit e47ba02

Browse files
fix(breadcrumbs): remove underlines (#19)
* separate the doc variants * nix breadcrumb's underline
1 parent 73a3d3a commit e47ba02

File tree

2 files changed

+53
-26
lines changed

2 files changed

+53
-26
lines changed

apps/dialtone-documentation/docs/components/breadcrumbs.md

Lines changed: 48 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,9 @@ image: assets/images/components/breadcrumbs.png
77
storybook: https://vue.dialpad.design/?path=/story/components-breadcrumbs--default
88
figma_url: https://www.figma.com/file/2adf7JhZOncRyjYiy2joil/DT-Core%3A-Components-7?node-id=8918%3A21306&viewport=-61%2C443%2C1.12&t=xHutRjwo1o5zMTgT-11
99
---
10+
1011
<code-well-header>
11-
<nav class="d-breadcrumbs d-bgc-primary d-py16 d-px12" aria-label="breadcrumb">
12+
<nav class="d-breadcrumbs" aria-label="breadcrumb">
1213
<ol>
1314
<li class="d-breadcrumbs__item">
1415
<a href="#" class="d-link d-link--muted">Root</a>
@@ -47,8 +48,10 @@ Breadcrumbs are always treated as secondary and should not entirely replace the
4748

4849
## Variants and examples
4950

51+
### Default
52+
5053
<code-well-header>
51-
<nav class="d-breadcrumbs d-bgc-primary d-py16 d-px12" aria-label="breadcrumb">
54+
<nav class="d-breadcrumbs" aria-label="breadcrumb">
5255
<ol>
5356
<li class="d-breadcrumbs__item">
5457
<a href="#" class="d-link d-link--muted">Root</a>
@@ -67,25 +70,6 @@ Breadcrumbs are always treated as secondary and should not entirely replace the
6770
</li>
6871
</ol>
6972
</nav>
70-
<nav class="d-breadcrumbs d-breadcrumbs--inverted d-bgc-contrast d-py16 d-px12 d-mt0" aria-label="inverted breadcrumb">
71-
<ol>
72-
<li class="d-breadcrumbs__item">
73-
<a href="#" class="d-link d-link--inverted">Root</a>
74-
</li>
75-
<li class="d-breadcrumbs__item">
76-
<a href="#" class="d-link d-link--inverted">Section</a>
77-
</li>
78-
<li class="d-breadcrumbs__item">
79-
<a href="#" class="d-link d-link--inverted">Section</a>
80-
</li>
81-
<li class="d-breadcrumbs__item">
82-
<a href="#" class="d-link d-link--inverted">Section</a>
83-
</li>
84-
<li class="d-breadcrumbs__item d-breadcrumbs__item--selected">
85-
<a href="#" class="d-link d-link--inverted" aria-current="location">Current Page</a>
86-
</li>
87-
</ol>
88-
</nav>
8973
</code-well-header>
9074

9175
```html
@@ -108,12 +92,50 @@ Breadcrumbs are always treated as secondary and should not entirely replace the
10892
</li>
10993
</ol>
11094
</nav>
111-
<nav class="d-breadcrumbs d-breadcrumbs--inverted" aria-label="breadcrumb">
95+
```
96+
97+
### Inverted
98+
99+
<code-well-header class="d-bgc-contrast">
100+
<nav class="d-breadcrumbs d-breadcrumbs--inverted d-bgc-contrast" aria-label="inverted breadcrumb">
101+
<ol>
102+
<li class="d-breadcrumbs__item">
103+
<a href="#" class="d-link d-link--inverted">Root</a>
104+
</li>
105+
<li class="d-breadcrumbs__item">
106+
<a href="#" class="d-link d-link--inverted">Section</a>
107+
</li>
108+
<li class="d-breadcrumbs__item">
109+
<a href="#" class="d-link d-link--inverted">Section</a>
110+
</li>
111+
<li class="d-breadcrumbs__item">
112+
<a href="#" class="d-link d-link--inverted">Section</a>
113+
</li>
114+
<li class="d-breadcrumbs__item d-breadcrumbs__item--selected">
115+
<a href="#" class="d-link d-link--inverted" aria-current="location">Current Page</a>
116+
</li>
117+
</ol>
118+
</nav>
119+
</code-well-header>
120+
121+
```html
122+
<nav class="d-breadcrumbs d-breadcrumbs--inverted" aria-label="inverted breadcrumb">
112123
<ol>
113-
<li class="d-breadcrumbs__item">
114-
<a href="#" class="d-link d-link--inverted">Root</a>
115-
</li>
116-
...
124+
<li class="d-breadcrumbs__item">
125+
<a href="#" class="d-link d-link--inverted">Root</a>
126+
</li>
127+
<li class="d-breadcrumbs__item">
128+
<a href="#" class="d-link d-link--inverted">Section</a>
129+
</li>
130+
<li class="d-breadcrumbs__item">
131+
<a href="#" class="d-link d-link--inverted">Section</a>
132+
</li>
133+
<li class="d-breadcrumbs__item">
134+
<a href="#" class="d-link d-link--inverted">Section</a>
135+
</li>
136+
<li class="d-breadcrumbs__item d-breadcrumbs__item--selected">
137+
<a href="#" class="d-link d-link--inverted" aria-current="location">Current Page</a>
138+
</li>
117139
</ol>
118140
</nav>
119141
```

packages/dialtone/lib/build/less/components/breadcrumbs.less

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,11 @@
6565

6666
.d-link {
6767
color: var(--breadcrumbs-color-text);
68+
text-decoration: none;
69+
70+
&:hover {
71+
text-decoration: underline;
72+
}
6873
}
6974

7075
// -- SELECTED STATE (CURRENT PAGE)

0 commit comments

Comments
 (0)