Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch jump table is treated as part of the function #16

Closed
Predelnik opened this issue Apr 21, 2019 · 3 comments
Closed

Switch jump table is treated as part of the function #16

Predelnik opened this issue Apr 21, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@Predelnik
Copy link

I don't know if it's related to #11 and/or deficiency of pdb but seems like switch jump table is added to diff and also incorrectly parsed as a code. You can easily test it on OperateObject function:
image

@AJenbo
Copy link
Member

AJenbo commented Apr 22, 2019

Switching to .map might solve it. I looked into .map recently build couldn't find any tool that was willing to parse the function names, but they actually seem to be easy to parse so maybe we could write our own function for it.

@seritools
Copy link
Collaborator

I don't think switching to .map will solve it - the map files don't include any function size info, and if they did, it would probably be the same as the pdb one. I'd rather argue that the comparer-config.toml should include the jump table as well, since it's technically a part of the function :)

Display-wise, this could definitely be improved though.

Dunno if y'all seen it, but I've started working on a more general tool for comparisons: https://github.com/seritools/bin-exact
In there it'll be much easier to add multiple sources like pdb, map, toml, etc., which can be configured and used separately as well.

@seritools seritools added the enhancement New feature or request label Apr 22, 2019
@seritools
Copy link
Collaborator

seritools commented Jun 14, 2019

In the current stage of the devilution project it's fixed/circumvented by https://github.com/diasurgical/devilution-comparer/releases/tag/v0.4.0, so closing for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants