Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Setting WEBSITE_SHOW_VERSION to false causes frontend not to load. #450

Closed
preeefix opened this issue Aug 21, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@preeefix
Copy link

What happened?

Setting WEBSITE_SHOW_VERSION to false causes version.data.data.versions to be undefined and the frontend to crash.

With the option set to false:
image

With the option set to true:
image

Likely this is due to the client expecting a positive result (200 with a value), however the dashboard isn't handling this tuple correctly. Although isSuccess is false, the frontend is still trying to render version.data.versions.current which because version.data.versions is undefined, the object it's trying to refer to will throw a TypeError.

Version

latest (ghcr.io/diced/zipline or ghcr.io/diced/zipline:latest)

What browser(s) are you seeing the problem on?

Firefox

Zipline Logs

2023-08-21 04:13:45,021 AM info  [datasource] using Local(./uploads) datasource
2023-08-21 04:13:45,055 AM info  [database::migrations] establishing database connection
2023-08-21 04:13:45,055 AM info  [database::migrations] ensuring database exists, if not creating database - may error if no permissions
2023-08-21 04:13:45,303 AM info  [database::migrations] exiting migrations engine - database is up to date
2023-08-21 04:13:46,794 AM info  [server] listening on 0.0.0.0:3000
2023-08-21 04:13:46,794 AM info  [server] started production zipline@3.7.3 server
2023-08-21 04:14:03,280 AM info  [server::response] GET /dashboard -> 200

Browser Logs

![image](https://github.com/diced/zipline/assets/1700460/98d32f7b-8e30-44dc-855b-a80865b64a82)

Additional Info

No response

@preeefix preeefix added the bug Something isn't working label Aug 21, 2023
@github-actions github-actions bot added this to the 3.7.1 milestone Aug 21, 2023
@diced
Copy link
Owner

diced commented Aug 29, 2023

Fixed in 5d67680

@diced diced closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants