@eleniv3d Thanks ! I took the liberty of linking the issues, so they are closed automatically when merging.

I was just looking at the per-face metric issue. Do you see a clear way to solve it ? I'm just diving in and it's not 100% clear to me how we can do that the most efficiently.

@eleniv3d Thanks ! I took the liberty of linking the issues, so they are closed automatically when merging.

I was just looking at the per-face metric issue. Do you see a clear way to solve it ? I'm just diving in and it's not 100% clear to me how we can do that the most efficiently.

@DamienGilliard
I guess one way could be to already segment the pcd per face with a similar mechanism as for the joints. Perhaps the joint segmentator could already output clusters for faces directly if it doesn't add to the calculation time. Then the pcd2mesh distance would automatically know that it is calculating for every face and will pop the corresponding message as is now the case for joints vs beams

The other way would be to specify that we want the calculation to happen per face with another toggle or ideally if we manage to make issue #116 work. but then again the distance calculation would look in the whole pcd of the joint.

@DamienGilliard
I guess one way could be to already segment the pcd per face with a similar mechanism as for the joints. Perhaps the joint segmentator could already output clusters for faces directly if it doesn't add to the calculation time. Then the pcd2mesh distance would automatically know that it is calculating for every face and will pop the corresponding message as is now the case for joints vs beams

can we not use the DFFace's brep face instead of the entire brep when doing the calculation of the error @eleniv3d ? And repeat it for each DFFace. I have some doubts about having an extra clustering component just for faces.

The other way would be to specify that we want the calculation to happen per face with another toggle or ideally if we manage to make issue #116 work. but then again the distance calculation would look in the whole pcd of the joint.

This could be nice and easy the same way we did it for the VIzSettings

@eleniv3d we do agree that you want a list of lists of pointclouds (and None if no pointcloud was found)? :
[[face_1_joint_1, face_2_joint_1, ...], [face_1_joint_2, face_2_joint_2, ...], ..., [face_1_joint_n, face_2_joint_n...]]
(Just double checking, I am the kind of person who messes this kind of things easily)

@eleniv3d we do agree that you want a list of lists of pointclouds (and None if no pointcloud was found)? : [[face_1_joint_1, face_2_joint_1, ...], [face_1_joint_2, face_2_joint_2, ...], ..., [face_1_joint_n, face_2_joint_n...]] (Just double checking, I am the kind of person who messes this kind of things easily)

Sounds good!