-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements error viz #115
base: main
Are you sure you want to change the base?
Conversation
@eleniv3d Thanks ! I took the liberty of linking the issues, so they are closed automatically when merging. I was just looking at the per-face metric issue. Do you see a clear way to solve it ? I'm just diving in and it's not 100% clear to me how we can do that the most efficiently. |
@DamienGilliard The other way would be to specify that we want the calculation to happen per face with another toggle or ideally if we manage to make issue #116 work. but then again the distance calculation would look in the whole pcd of the joint. |
can we not use the DFFace's brep face instead of the entire brep when doing the calculation of the error @eleniv3d ? And repeat it for each DFFace. I have some doubts about having an extra clustering component just for faces.
This could be nice and easy the same way we did it for the VIzSettings |
@eleniv3d we do agree that you want a list of lists of pointclouds (and None if no pointcloud was found)? : |
Sounds good! |
Still work in progress. I open it for discussion and in order to keep track of what's missing
o_success
output for csv exporter #86_legend
#80-> implemented as a per_item toggle
-> implemented if pcd input is already segmented per face