Skip to content

Commit 47c40e8

Browse files
Refactor to use new getter
Avoids directory list calls we do lose the valid name thing but I think at this point that will have to be something else. e.g. a tutorial where we call `print(project.directory.get_directory_list())`
1 parent a0fbf4b commit 47c40e8

File tree

1 file changed

+2
-23
lines changed

1 file changed

+2
-23
lines changed

sdk/diffgram/core/core.py

+2-23
Original file line numberDiff line numberDiff line change
@@ -296,29 +296,8 @@ def set_directory_by_name(self, name):
296296
297297
"""
298298

299-
if name is None:
300-
raise Exception("No name provided.")
301-
302-
# Don't refresh by default, just set from existing
303-
304-
names_attempted = []
305-
did_set = False
306-
307-
if not self.directory_list:
308-
self.directory_list = self.directory.get_directory_list()
309-
310-
for directory in self.directory_list:
311-
312-
if directory.nickname == name:
313-
self.set_default_directory(directory = directory)
314-
did_set = True
315-
break
316-
else:
317-
names_attempted.append(directory.nickname)
318-
319-
if did_set is False:
320-
raise Exception(name, " does not exist. Valid names are: " +
321-
str(names_attempted))
299+
directory = self.directory.get(name = name)
300+
self.set_default_directory(directory = directory)
322301

323302

324303
def set_default_directory(self,

0 commit comments

Comments
 (0)