Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the ARIA design pattern for the datepicker component #206

Open
Veyfeyken opened this issue Feb 3, 2021 · 0 comments
Open

Follow the ARIA design pattern for the datepicker component #206

Veyfeyken opened this issue Feb 3, 2021 · 0 comments
Labels
accessibility Accessibility can be improved

Comments

@Veyfeyken
Copy link

Problem

  • The datepicker cannot be openend with the keyboard or a screenreader. The icon that opens the datepicker is an empty span.
<span class="fa fa-calendar is-clickable"></span>
  • The ARIA role="application" on the parent div puts screenreaders in a different mode, this overrides all normal navigation methods. In short, never use role="application" unless it's absolutely necessary. It rarely is.
<div class="m-datepicker__nav" role="application" aria-label="Datumkiezer dagen" aria-hidden="false">
  • The modal dialog is not modal. It's possible the navigate outside the modal with the keyboard or a screenreader.
  • Every button has been given an aria-label with the full date. Although well intended, this seems counterproductive. If you follow the ARIA design pattern and markup, there is no need to add aria-labels on the buttons. The extra verbosity may slow the user down.

Suggestion

Follow the ARIA design pattern for datepicker dialog.

Articles and demo

@TriangleJuice TriangleJuice added the accessibility Accessibility can be improved label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Accessibility can be improved
Projects
None yet
Development

No branches or pull requests

2 participants