Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Validation #14

Closed
mattcollier opened this issue Jan 15, 2020 · 8 comments
Closed

HTTP Validation #14

mattcollier opened this issue Jan 15, 2020 · 8 comments
Assignees

Comments

@mattcollier
Copy link
Contributor

Work has begun here: https://github.com/digitalbazaar/bedrock-vc-issuer/tree/http-validation

Here is a sample presentation: https://gist.github.com/mattcollier/349fe541d793e0d61280254f554e2922#file-vp-json-L4

@mattcollier
Copy link
Contributor Author

@aljones15 The test that have been written so far are all passing at this moment, if you see anything other than that, please let me know.

@mattcollier
Copy link
Contributor Author

The presentation schema was automagically created using this tool: https://jsonschema.net/

I figured that would make a good starting point. The idea was to break out capability into a separate schema etc. Also, probably want to remove the automatically generated wildcard pattern thing unless it's useful.

@aljones15
Copy link
Contributor

aljones15 commented Jan 15, 2020

@mattcollier
Copy link
Contributor Author

@aljones15 there is now this branch which will hopefully be released soon: https://github.com/digitalbazaar/bedrock-credentials-context/tree/new-url

If you use this in the same way as bedrock-security-context you will be able to pull the URLcontext URL constant instead of using the string literal.

https://gist.github.com/mattcollier/349fe541d793e0d61280254f554e2922#file-vp-json-L4

I'll keep you posted on when bedrock-credentials-context is released.

@mattcollier
Copy link
Contributor Author

bdrock-credentials-context@1 released: https://github.com/digitalbazaar/bedrock-credentials-context

@aljones15
Copy link
Contributor

aljones15 commented Jan 16, 2020

  • use bedrock-credentials-context and the resulting constants to specify the jsonLd.context for the schemas.

  • double check data model against schemas

  • suggest potential RegExps

@aljones15
Copy link
Contributor

@mattcollier should we consider this closed now?

@mattcollier
Copy link
Contributor Author

Created a new issue for further work: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants