Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make customization easier #62

Open
mahmoudbahaa opened this issue Sep 19, 2011 · 0 comments
Open

make customization easier #62

mahmoudbahaa opened this issue Sep 19, 2011 · 0 comments

Comments

@mahmoudbahaa
Copy link

it is not actually a bug but a request

in XMLHTTPServiceProvider urlSuffix & serializer are declared protected

protected var urlSuffix:String;

protected var serializer:ISerializer;

so one needs to subclass to modify them if they were declared public or had setter it would make changing them easier for those who want to use for example standard xml format instead of fxml or want to use a customized serializer

Also in XML serializer ID need to be give as a child tag of the node but sometimes it is given as an attribute instead so changing

var node:XML = XML(source);
.....
var nodeId:String = node.id;
.....

to

var node:XML = XML(source);
.....
var nodeId:String = node.id;
if(!nodeId)
      node.attribute("id");
.....

would make it more adoptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant