add better async compatibility #354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @jrnxf! I hope we can get the maintainers to look at this sooner rather than later! |
|
+1 also dealing with this issue |
|
What a legend! 👏 @pacocoursey does this need some input? EDIT: |
Author
|
@pacocoursey any chance we could get a review on this one? Would love to get this out ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #280, when dealing with asynchronous fetching and a dynamic list of options, the first item is not always selected an you'd expect. Additionally, as you start typing and update your query, even though the data fetching is async, the selected item jumps to the top (instead of staying where it is), the async options update, and the first item is not highlighted.
If the overall change is acceptable I'll update the README and get everything polished.
Here's a before and after:
Before:
before.mov
After:
after.mov