Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False report of issue with com.microsoft.appcenter:espresso-test-extension:1.4 #76

Open
trevorhackman opened this issue Nov 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@trevorhackman
Copy link

Describe the bug

A false report of an issue that doesn't actually exist is given by bye bye jetifier:

Scanning com.microsoft.appcenter:espresso-test-extension:1.4
 Absolute path: /Users/P2956789/.gradle/caches/modules-2/files-2.1/com.microsoft.appcenter/espresso-test-extension/1.4/d95d919a5195d439334f79834fc5c6bc1dada78a/espresso-test-extension-1.4.aar
 Graphs to this dependency:
 +---com.microsoft.appcenter:espresso-test-extension:1.4
 Issues found:
 * com/microsoft/appcenter/espresso/Factory.class -> android.support.test.InstrumentationRegistry

To Reproduce
Steps to reproduce the behavior:

  1. Have com.microsoft.appcenter:espresso-test-extension:1.4 as a dependency
  2. Use bye bye jetifier
  3. See false report of an issue with it

Expected behavior
I shouldn't see a report of an issue with appcenter.

Additional context

If you look at the open source code, https://github.com/microsoft/AppCenter-Test-Espresso-Extensions/blob/master/src/main/java/com/microsoft/appcenter/espresso/Factory.java, you can see that android.support is used in a string literal but it is not actually used as an import or dependency anywhere. So this appcenter stuff does not block you from disabling Jetifier.

@trevorhackman trevorhackman added the bug Something isn't working label Nov 16, 2022
@PatrickSpies
Copy link

Same issue with current version of org.robolectric:robolectric:

Scanning org.robolectric:sandbox:4.10
 Absolute path: /root/.gradle/caches/modules-2/files-2.1/org.robolectric/sandbox/4.10/ded1312bc48e74c93d2de0b978e063991d7523bb/sandbox-4.10.jar
 Graphs to this dependency:
 +---org.robolectric:robolectric:4.10
     +---org.robolectric:sandbox:4.10
 +---org.robolectric:robolectric:4.10
     +---org.robolectric:junit:4.10
          +---org.robolectric:sandbox:4.10
 +---org.robolectric:robolectric:4.10
     +---org.robolectric:shadows-framework:4.10
          +---org.robolectric:sandbox:4.10
 Issues found:
 * org/robolectric/config/AndroidConfigurer.class -> android.support.constraint.
 * org/robolectric/config/AndroidConfigurer.class -> android.support.v7.view.
> Task :canISayByeByeJetifier FAILED

https://github.com/robolectric/robolectric/blob/master/sandbox/src/main/java/org/robolectric/config/AndroidConfigurer.java

...
    // Don't acquire legacy support packages.
    builder
        .doNotInstrumentPackage("android.support.constraint.")
        .doNotInstrumentPackage("android.support.v7.view.");
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants