Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "What's new" page #743

Merged
merged 5 commits into from
Aug 1, 2021
Merged

Conversation

Danktuary
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
This adds a "What's new" page for the release of discord.js v13. It lists a few site changes, the new pages, and the notable updated content.

@J-Human
Copy link
Contributor

J-Human commented Aug 1, 2021

It would be nice if there are automated bots/workflows that can detect new pages and generate new content + PR it but I think it's too complicated. But that aside, I love it!

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, LGTM otherwise!

@WiseDevHelper
Copy link
Contributor

A few questions:

  • Going forward, will content be added to by users in their PRs?
  • Will this page adopt a changelog style?
  • Will changes too old be removed?
  • Could this possibly be re-implemented or replaced with components later?

@WiseDevHelper
Copy link
Contributor

This resolves #664

Danktuary and others added 2 commits August 1, 2021 10:33
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
@Danktuary
Copy link
Member Author

Danktuary commented Aug 1, 2021

A few questions:

  • Going forward, will content be added to by users in their PRs?
  • Will this page adopt a changelog style?
  • Will changes too old be removed?
  • Could this possibly be re-implemented or replaced with components later?
  1. Probably not, this page is to raise awareness about v13's release and the new content we have relevant to it. Consider it temporary
  2. It'll stay as is
  3. Anything here will be staying until the page is removed
  4. This may eventually be reimplemented as a changelog style page with components

This resolves #664

It doesn't; I'll make a better implementation to resolve that issue

@Danktuary Danktuary merged commit 81990d2 into discordjs:v13-prep Aug 1, 2021
@Brennvo
Copy link

Brennvo commented Aug 1, 2021

I'm a bit confused. I just started using Discord.js a couple of days ago, so I'm just finding this guide. I refreshed the guide and see the docs mentioning v13, but I can't seem to install v13. I checked the Discord.js repo itself, and it seems that it's still on v12. When is v13 expected to be released?

@almostSouji
Copy link
Member

We are still working on the finishing touches for v13, but want the guide to be up to speed before a new major version. The v12 guide is archived and available at http://v12.discordjs.guide/. If you want to check out v13 before its official release you can install npm i discord.js@dev.

If you require more in-detail help check out the specific feature support channels on our discord server at https://discord.gg/djs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants