From bded47d2ce40d3b300979e53dce5c021f45bb03c Mon Sep 17 00:00:00 2001 From: Kelvin Tan Date: Tue, 2 Jul 2024 13:11:29 +0800 Subject: [PATCH] DEV: read deprecation ids from separate file --- lib/deprecation_collector/deprecation-ids.yml | 85 +++++++++++++++++ lib/deprecation_collector/list.rb | 94 ++----------------- 2 files changed, 93 insertions(+), 86 deletions(-) create mode 100644 lib/deprecation_collector/deprecation-ids.yml diff --git a/lib/deprecation_collector/deprecation-ids.yml b/lib/deprecation_collector/deprecation-ids.yml new file mode 100644 index 0000000..5803b51 --- /dev/null +++ b/lib/deprecation_collector/deprecation-ids.yml @@ -0,0 +1,85 @@ +--- +ember_deprecation_ids: +- deprecate-implicit-route-model +discourse_deprecation_ids: +- discourse.pretty-text.registerOption +- discourse.add-flag-property +- discourse.add-header-icons +- discourse.add-header-panel +- discourse.add-toolbar-popup-menu-options-callback +- discourse.add-user-menu-glyph +- discourse.application-show-footer +- discourse.avatar-utils +- discourse.bootbox +- discourse.breadcrumbs.childCategories +- discourse.breadcrumbs.firstCategory +- discourse.breadcrumbs.parentCategories +- discourse.breadcrumbs.parentCategoriesSorted +- discourse.breadcrumbs.parentCategory +- discourse.breadcrumbs.secondCategory +- discourse.capitalize-string +- discourse.category-hashtags.categoryHashtagTriggerRule +- discourse.click-track.is-valid-link-jquery +- discourse.composer-controller.clear-popup-menu-options-callback +- discourse.composer.usernames +- discourse.createNewMessageViaParams +- discourse.createNewTopicViaParams +- discourse.current-theme-key +- discourse.custom_html_template +- discourse.d-button-action-string +- discourse.d-editor.on-toolbar-create +- discourse.d-popover +- discourse.d-section +- discourse.decorate-plugin-outlet +- discourse.decorate-topic-title +- discourse.formatter.update-relative-age-node-list +- discourse.get-owner-with-fallback +- discourse.global.site +- discourse.global.site-settings +- discourse.global.user +- discourse.globals.site +- discourse.globals.user +- discourse.hashtag.cleanUpHashtagTypeClasses +- discourse.hashtag.decorateHashtags +- discourse.hashtag.fetchUnseenHashtagsInContext +- discourse.hashtag.generatePlaceholderHashtagHTML +- discourse.hashtag.getHashtagTypeClasses +- discourse.hashtag.linkSeenHashtagsInContext +- discourse.hashtag.registerHashtagType +- discourse.header-extra-info.needs-second-row-if +- discourse.header-widget-overrides +- discourse.icon-renderer-translatedtitle +- discourse.inline-date +- discourse.lightbox.default-export +- discourse.link-hashtags.dom-node +- discourse.markdown-it.whitelist +- discourse.modal-controllers +- discourse.models-store +- discourse.nav-item.built-list-site-settings +- discourse.number-field +- discourse.open-topic-draft +- discourse.period-mixin +- discourse.plugin-connector.deprecated-arg +- discourse.plugin-outlet-args +- discourse.plugin-outlet-classic-hooks +- discourse.plugin-outlet-context-get +- discourse.plugin-outlet-parent-view +- discourse.plugin-outlet-tag-name +- discourse.post-stream.trigger-new-post +- discourse.qunit.acceptance-function +- discourse.qunit.global-exists +- discourse.register-connector-class-legacy +- discourse.register-unbound +- discourse.resolver-resolutions +- discourse.section-link-class-arg +- discourse.select-kit +- discourse.this-container +- discourse.topic.totalUnread +- discourse.uploads.display-error-for-upload +- discourse.user.userOptions +- discourse.user-menu.panel-component-class +- discourse.utils-decorators-import +- discourse.utils-decorators-observes +- discourse.utils-decorators-on +- discourse.hide-popover +- discourse.show-popover diff --git a/lib/deprecation_collector/list.rb b/lib/deprecation_collector/list.rb index c1d1320..12c1aa6 100644 --- a/lib/deprecation_collector/list.rb +++ b/lib/deprecation_collector/list.rb @@ -1,91 +1,13 @@ # frozen_string_literal: true +require "yaml" # required for Github workflows depending on this module outside of core to work + module DeprecationCollector + DEPRECATION_IDS_FILE = File.expand_path("../deprecation-ids.yml", __FILE__) + + deprecations = YAML.load_file(DEPRECATION_IDS_FILE) List = - # Ember deprecations (generated by `/list_ember_deprecations.rb`) - %w[deprecate-implicit-route-model] + - # discourse deprecations - %w[ - discourse.pretty-text.registerOption - discourse.add-flag-property - discourse.add-header-icons - discourse.add-header-panel - discourse.add-toolbar-popup-menu-options-callback - discourse.add-user-menu-glyph - discourse.application-show-footer - discourse.avatar-utils - discourse.bootbox - discourse.breadcrumbs.childCategories - discourse.breadcrumbs.firstCategory - discourse.breadcrumbs.parentCategories - discourse.breadcrumbs.parentCategoriesSorted - discourse.breadcrumbs.parentCategory - discourse.breadcrumbs.secondCategory - discourse.capitalize-string - discourse.category-hashtags.categoryHashtagTriggerRule - discourse.click-track.is-valid-link-jquery - discourse.composer-controller.clear-popup-menu-options-callback - discourse.composer.usernames - discourse.createNewMessageViaParams - discourse.createNewTopicViaParams - discourse.current-theme-key - discourse.custom_html_template - discourse.d-button-action-string - discourse.d-editor.on-toolbar-create - discourse.d-popover - discourse.d-section - discourse.decorate-plugin-outlet - discourse.decorate-topic-title - discourse.formatter.update-relative-age-node-list - discourse.get-owner-with-fallback - discourse.global.site - discourse.global.site-settings - discourse.global.user - discourse.globals.site - discourse.globals.user - discourse.hashtag.cleanUpHashtagTypeClasses - discourse.hashtag.decorateHashtags - discourse.hashtag.fetchUnseenHashtagsInContext - discourse.hashtag.generatePlaceholderHashtagHTML - discourse.hashtag.getHashtagTypeClasses - discourse.hashtag.linkSeenHashtagsInContext - discourse.hashtag.registerHashtagType - discourse.header-extra-info.needs-second-row-if - discourse.header-widget-overrides - discourse.icon-renderer-translatedtitle - discourse.inline-date - discourse.lightbox.default-export - discourse.link-hashtags.dom-node - discourse.markdown-it.whitelist - discourse.modal-controllers - discourse.models-store - discourse.nav-item.built-list-site-settings - discourse.number-field - discourse.open-topic-draft - discourse.period-mixin - discourse.plugin-connector.deprecated-arg - discourse.plugin-outlet-args - discourse.plugin-outlet-classic-hooks - discourse.plugin-outlet-context-get - discourse.plugin-outlet-parent-view - discourse.plugin-outlet-tag-name - discourse.post-stream.trigger-new-post - discourse.qunit.acceptance-function - discourse.qunit.global-exists - discourse.register-connector-class-legacy - discourse.register-unbound - discourse.resolver-resolutions - discourse.section-link-class-arg - discourse.select-kit - discourse.this-container - discourse.topic.totalUnread - discourse.uploads.display-error-for-upload - discourse.user.userOptions - discourse.user-menu.panel-component-class - discourse.utils-decorators-import - discourse.utils-decorators-observes - discourse.utils-decorators-on - discourse.hide-popover - discourse.show-popover - ] + (deprecations["ember_deprecation_ids"] || []).concat( + deprecations["discourse_deprecation_ids"] || [], + ) end