From d27d5d368c1522b0127c4edbdf9a7f0fd053dcfe Mon Sep 17 00:00:00 2001
From: Marcus <marcustyphoon@gmail.com>
Date: Wed, 29 May 2024 19:15:11 -0700
Subject: [PATCH] simplify "pinned" / "starred" language in UI

---
 .../SavedResultManager/SavedResultManager.jsx      |  4 ++--
 .../sections/results/table/ResultTable.tsx         | 14 ++++----------
 .../results/table/ResultTableHeaderRow.tsx         |  5 +----
 .../sections/results/table/ResultTableRow.tsx      |  8 ++++----
 4 files changed, 11 insertions(+), 20 deletions(-)

diff --git a/src/components/sections/results/SavedResultManager/SavedResultManager.jsx b/src/components/sections/results/SavedResultManager/SavedResultManager.jsx
index 89cd510ed..352c20e4e 100644
--- a/src/components/sections/results/SavedResultManager/SavedResultManager.jsx
+++ b/src/components/sections/results/SavedResultManager/SavedResultManager.jsx
@@ -215,7 +215,7 @@ export default function SavedResultManager({ isOpen, setOpen }) {
 
       <DialogContent sx={{ padding: 2 }} dividers>
         <Typography sx={{ fontWeight: 200 }}>
-          <Trans>Temporary saved builds</Trans>{' '}
+          <Trans>Current pinned builds</Trans>{' '}
           <HelperIcon
             text={t('These builds will be deleted after you leave or refresh this page.')}
             size="small"
@@ -343,7 +343,7 @@ export default function SavedResultManager({ isOpen, setOpen }) {
                       </IconButton>
                     </Tooltip>
 
-                    <Tooltip title={t('Copy build to temporary saved builds')}>
+                    <Tooltip title={t('Load as pinned build')}>
                       <IconButton onClick={handleCopyToTemporary(character)}>
                         <ArrowCircleUpIcon fontSize="small" />
                       </IconButton>
diff --git a/src/components/sections/results/table/ResultTable.tsx b/src/components/sections/results/table/ResultTable.tsx
index 6e1c9f24c..37647807f 100644
--- a/src/components/sections/results/table/ResultTable.tsx
+++ b/src/components/sections/results/table/ResultTable.tsx
@@ -1,12 +1,11 @@
-import { HelperIcon } from '@discretize/react-discretize-components';
-import ManageAccountsIcon from '@mui/icons-material/ManageAccounts';
+import SaveAsIcon from '@mui/icons-material/SaveAs';
 import { Box, IconButton, Typography } from '@mui/material';
 import Table from '@mui/material/Table';
 import TableBody from '@mui/material/TableBody';
 import TableContainer from '@mui/material/TableContainer';
 import TableHead from '@mui/material/TableHead';
 import React from 'react';
-import { Trans, useTranslation } from 'react-i18next';
+import { Trans } from 'react-i18next';
 import { useSelector } from 'react-redux';
 import { makeStyles } from 'tss-react/mui';
 import type { Character } from '../../../../state/optimizer/optimizerCore';
@@ -71,7 +70,6 @@ const emptyList: Character[] = [];
 
 const StickyHeadTable = () => {
   const { classes, cx } = useStyles();
-  const { t } = useTranslation();
 
   const [managerOpen, setManagerOpen] = React.useState(false);
 
@@ -217,15 +215,11 @@ const StickyHeadTable = () => {
 
       <Box className={classes.tablehead} sx={{ display: 'flex', alignItems: 'center' }}>
         <Typography sx={{ flexGrow: 1, ml: 2, fontWeight: 600, fontFamily: 'Raleway' }}>
-          <Trans>Saved Results</Trans>{' '}
-          <HelperIcon
-            text={t('Click the star icon to save a result for comparison.')}
-            fontSize="1rem"
-          />
+          <Trans>Pinned Results</Trans>{' '}
         </Typography>
 
         <IconButton size="small" sx={{ margin: 1 }} onClick={() => setManagerOpen(true)}>
-          <ManageAccountsIcon />
+          <SaveAsIcon />
         </IconButton>
         <SavedResultManager isOpen={managerOpen} setOpen={setManagerOpen} />
       </Box>
diff --git a/src/components/sections/results/table/ResultTableHeaderRow.tsx b/src/components/sections/results/table/ResultTableHeaderRow.tsx
index d3eff3560..bd721387a 100644
--- a/src/components/sections/results/table/ResultTableHeaderRow.tsx
+++ b/src/components/sections/results/table/ResultTableHeaderRow.tsx
@@ -76,10 +76,7 @@ const ResultTableHeaderRow = ({
   return (
     <TableRow>
       <TableCell className={classes.tablehead} align="center" padding="none">
-        <HelperIcon
-          text={t('Click the star icon to save a result for comparison.')}
-          fontSize="1rem"
-        />
+        <HelperIcon text={t('Pin results for comparison between calculations.')} fontSize="1rem" />
       </TableCell>
       <TableCell className={classes.tablehead}>
         {t('priorityGoal', {
diff --git a/src/components/sections/results/table/ResultTableRow.tsx b/src/components/sections/results/table/ResultTableRow.tsx
index 3a2bddfdf..07d59855d 100644
--- a/src/components/sections/results/table/ResultTableRow.tsx
+++ b/src/components/sections/results/table/ResultTableRow.tsx
@@ -1,6 +1,6 @@
 import { Item, Profession } from '@discretize/gw2-ui-new';
 import CloseIcon from '@mui/icons-material/Close';
-import StarRoundedIcon from '@mui/icons-material/StarRounded';
+import PushPinIcon from '@mui/icons-material/PushPin';
 import { Typography } from '@mui/material';
 import TableCell from '@mui/material/TableCell';
 import TableRow from '@mui/material/TableRow';
@@ -100,17 +100,17 @@ const ResultTableRow = ({
             }}
           />
         ) : (
-          <StarRoundedIcon
+          <PushPinIcon
             sx={
               saved
                 ? {
-                    color: 'star',
+                    color: 'primary.main',
                   }
                 : {
                     opacity: '0.2',
                     '&:hover': {
                       opacity: '1',
-                      color: 'star',
+                      color: 'primary.main',
                     },
                   }
             }