Skip to content

NsEnhancedDeckUx bugs & features #5

@dithpri

Description

@dithpri

Bugs:

  • Buttons duplicate when expression is changed
  • Should be disabled on card pages & show_market=decks
  • asHtmlDataSetKey doesn't convert apostrophes/other invalid chars: script errors out on "nation's bids" page
    • Suggestion: treat that page's "nation's bids/asks/etc." columns as a special case
  • Expression input breaks when pressing a keybind (I should've seen that coming!)
    • Suggestion: use Mousetrap instead

Features:

  • Update DV/Bank on junk
  • Add default_flag/game_flag boolean for use in expressions
  • Add puppet value for use in expressions (body.dataset.nname)
  • Use Mousetrap to not go crazy handling keybinds
  • Switch to last page of deck first when using keybinds, go to previous page when processing is complete
  • Close tab after finishing processing
  • Highlight mismatched ask/bid (or just highlight the Match column)
  • Sort when clicking on a column header

Misc:

  • Extract part of the filtering function to the Row class

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions