Skip to content

Commit 471228b

Browse files
authored
Merge pull request #76 from rsalmaso/isort
Isort configuration
2 parents b543c15 + 73ab5a0 commit 471228b

28 files changed

+50
-59
lines changed

django_nyt/admin.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
from django.contrib import admin
22
from django.utils.translation import gettext as _
3-
4-
from django_nyt import models
5-
from django_nyt import settings
3+
from django_nyt import models, settings
64

75

86
class SettingsAdmin(admin.ModelAdmin):

django_nyt/decorators.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import json
2-
32
from functools import wraps
43

5-
from django.http import HttpResponse
6-
from django.contrib.auth.decorators import login_required
7-
84
import django_nyt
5+
from django.contrib.auth.decorators import login_required
6+
from django.http import HttpResponse
97

108

119
def disable_notify(f):

django_nyt/management/commands/notifymail.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,8 @@
1010
from django.core import mail
1111
from django.core.management.base import BaseCommand
1212
from django.template.loader import render_to_string
13-
from django.utils.translation import gettext as _
14-
from django.utils.translation import activate, deactivate
15-
from django_nyt import settings as nyt_settings
16-
from django_nyt import models
13+
from django.utils.translation import activate, deactivate, gettext as _
14+
from django_nyt import models, settings as nyt_settings
1715

1816
# Daemon / mail loop sleep between each database poll (seconds)
1917
SLEEP_TIME = 120

django_nyt/migrations/0001_initial.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.db import models, migrations
1+
from django.db import migrations, models
22

33

44
class Migration(migrations.Migration):

django_nyt/migrations/0002_notification_settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from django.db import models, migrations
21
from django.conf import settings
2+
from django.db import migrations, models
33

44

55
class Migration(migrations.Migration):

django_nyt/migrations/0003_subscription.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.db import models, migrations
1+
from django.db import migrations, models
22

33

44
class Migration(migrations.Migration):

django_nyt/migrations/0004_notification_subscription.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from django.db import models, migrations
21
import django.db.models.deletion
2+
from django.db import migrations, models
33

44

55
class Migration(migrations.Migration):

django_nyt/migrations/0005__v_0_9_2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
from django.db import models, migrations
21
import django.db.models.deletion
32
from django.conf import settings
3+
from django.db import migrations, models
44

55

66
class Migration(migrations.Migration):

django_nyt/migrations/0006_auto_20141229_1630.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from django.db import models, migrations
1+
from django.db import migrations, models
22

33

44
class Migration(migrations.Migration):

django_nyt/migrations/0007_add_modified_and_default_settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from django.utils import timezone
21
from django.db import migrations, models
2+
from django.utils import timezone
33

44

55
class Migration(migrations.Migration):

django_nyt/migrations/0008_auto_20161023_1641.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1+
import django.db.models.deletion
12
from django.conf import settings
23
from django.db import migrations, models
3-
import django.db.models.deletion
44

55

66
class Migration(migrations.Migration):

django_nyt/subscribers.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
from channels import Group
44

5-
from . import settings
6-
from . import models
5+
from . import models, settings
76

87
logger = logging.getLogger(__name__)
98

django_nyt/tests/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
from .test_basic import * # noqa
2-
from .test_views import * # noqa
32
from .test_management import * # noqa
3+
from .test_views import * # noqa

django_nyt/tests/test_basic.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
from django.contrib.auth import get_user_model
22
from django.test import TestCase
3-
4-
from django_nyt import utils, models
3+
from django_nyt import models, utils
54

65
User = get_user_model()
76

django_nyt/tests/test_management.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
import os
22
import signal
33
import time
4+
from tempfile import NamedTemporaryFile
45

56
from django.core.management import call_command
67

8+
from .. import models, utils
79
from .test_basic import NotifyTestBase
8-
from .. import models
9-
from .. import utils
10-
from tempfile import NamedTemporaryFile
1110

1211

1312
class CommandTest(NotifyTestBase):

django_nyt/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from django import VERSION as DJANGO_VERSION
2-
from django.conf.urls import url, include
2+
from django.conf.urls import include, url
33

44
from . import views
55

django_nyt/utils.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
from django.db.models import Model
22
from django.utils.translation import gettext as _
33

4-
from . import _disable_notifications
5-
from . import models
6-
from . import settings
4+
from . import _disable_notifications, models, settings
75

86

97
def notify(message, key, target_object=None, url=None, filter_exclude={}, recipient_users=None):

django_nyt/views.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
from django.db.models import Q
2-
3-
from django_nyt.decorators import json_view, login_required_ajax
4-
from django_nyt import models
51
from django.contrib.auth.decorators import login_required
6-
from django.shortcuts import redirect, get_object_or_404
2+
from django.db.models import Q
3+
from django.shortcuts import get_object_or_404, redirect
74
from django.utils.translation import gettext as _
5+
from django_nyt import models
6+
from django_nyt.decorators import json_view, login_required_ajax
87

98

109
@login_required_ajax

runtests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
#!/usr/bin/env python
22
import os
33
import sys
4+
45
from django.conf import settings
6+
from django.core.management import execute_from_command_line
57

68
INSTALLED_APPS = [
79
'django.contrib.auth',
@@ -57,7 +59,6 @@
5759
)
5860

5961

60-
from django.core.management import execute_from_command_line
6162
argv = [sys.argv[0], "test"]
6263

6364
if len(sys.argv) == 1:

setup.cfg

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,13 @@ ignore = E226,E302,E303,E41,E501
99
max-line-length = 160
1010
max-complexity = 10
1111
exclude = */*migrations
12+
13+
[isort]
14+
combine_as_imports = true
15+
default_section = THIRDPARTY
16+
include_trailing_comma = true
17+
line_length = 160
18+
multi_line_output = 5
19+
not_skip = __init__.py
20+
skip = docs/conf.py
21+
indent = 4

setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import os
22

3-
from setuptools import find_packages, setup
4-
53
from django_nyt import __version__
4+
from setuptools import find_packages, setup
65

76

87
def get_path(fname):

test-project/testapp/admin.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22

33
from . import models
44

5-
65
admin.site.register(models.TestModel)

test-project/testapp/forms.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
from . import models
44

5+
56
class TestModelForm(forms.ModelForm):
67

78
class Meta:

test-project/testapp/migrations/0002_createtestusers.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
from django_nyt.utils import subscribe
33
from testapp.models import NOTIFICATION_TEST_KEY
44

5-
65
FIXTURES = (
76
('bob', 'bob@example.com'),
87
('alice', 'alice@example.com'),

test-project/testapp/models.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
import logging
22

3-
from django_nyt.utils import notify
4-
53
from django.db import models
64
from django.db.models.signals import post_save
75
from django.dispatch import receiver
86
from django.utils.translation import gettext as _
7+
from django_nyt.utils import notify
98

109
logger = logging.getLogger(__name__)
1110

test-project/testapp/views.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,14 @@
1-
from django.contrib.auth import get_user_model
2-
from django.contrib.auth import login
1+
from django.contrib.auth import get_user_model, login
32
from django.shortcuts import redirect
3+
from django.utils.decorators import method_decorator
44
from django.views.generic.base import TemplateView
55
from django.views.generic.detail import DetailView
66
from django.views.generic.edit import CreateView
7-
7+
from django_nyt.decorators import json_view
88
from django_nyt.forms import SettingsForm
99
from django_nyt.models import Notification, Settings
10-
from django_nyt.decorators import json_view
11-
12-
from . import forms
13-
from . import models
1410

15-
from django.utils.decorators import method_decorator
11+
from . import forms, models
1612

1713

1814
class TestIndex(TemplateView):

test-project/testproject/settings/__init__.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1+
import os
12
from os import path as os_path
3+
4+
from django import VERSION
5+
26
PROJECT_PATH = os_path.abspath(os_path.split(os_path.dirname(__file__))[0])
37

48
DEBUG = True
@@ -91,7 +95,6 @@
9195
'testapp',
9296
]
9397

94-
from django import VERSION
9598
if VERSION <= (1, 6):
9699
INSTALLED_APPS.append('south')
97100
SOUTH_MIGRATION_MODULES = {
@@ -101,7 +104,6 @@
101104
TEST_RUNNER = 'django.test.runner.DiscoverRunner'
102105

103106

104-
import os
105107

106108
LOGGING = {
107109
'version': 1,
@@ -152,6 +154,3 @@
152154

153155

154156
NYT_ENABLE_ADMIN = True
155-
156-
157-

test-project/testproject/urls.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import django.views.static
2+
from django.conf import settings
3+
from django.contrib import admin
4+
from django.contrib.staticfiles.urls import staticfiles_urlpatterns
25

36
try:
47
from django.urls import include, re_path as url
58
except ImportError:
69
from django.conf.urls import include, url
7-
from django.conf import settings
8-
from django.contrib.staticfiles.urls import staticfiles_urlpatterns
9-
from django.contrib import admin
1010

1111

1212
admin.autodiscover()

0 commit comments

Comments
 (0)