Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard coded 2 passes in for sample implementation of multiple pass encoding. #19

Closed
wants to merge 1 commit into from
Closed

Hard coded 2 passes in for sample implementation of multiple pass encoding. #19

wants to merge 1 commit into from

Conversation

ardeaf
Copy link

@ardeaf ardeaf commented May 31, 2017

Merge intended to be worked into future settings in pull request #16, simple implementation. Number of passes is hard coded for now at line 84.

This commit closes #6

ardeaf
ardeaf commented May 31, 2017
View reviewed changes
video_thread.py
# Reset the progress bar to 0.
progressBarValue = 0
print("\nStarted encoding pass {} of {}".format(pass_count, passes))

Copy link
Author

@ardeaf ardeaf May 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above line 95 are my additions. Starting at line 96 to line 143 is indented original code, except I updated the string on line 132 & 133.

@ardeaf ardeaf mentioned this pull request May 31, 2017
Open
@ardeaf ardeaf changed the title Hard coded 2 passes in for sample implementation of multiple passes. Hard coded 2 passes in for sample implementation of multiple pass encoding. Jun 3, 2017
@dv-anomaly
Copy link
Collaborator

@ardeaf The codebase has changed significantly since #16 our current working branch is feature-newgui there will most likely be some conflicts with this request. Multipass is a great idea. Are you willing to rebase and port this to the new branch? Please note however this should be optional and configurable by the user.

@ardeaf
Copy link
Author

ardeaf commented Jun 13, 2017

Didn't get a chance to respond, but willing to rebase once I get a better handle on FFMPEG as currently the simple change I did is incompatible with the default parameters we are passing into the ffmpeg command.

@dv-anomaly
Copy link
Collaborator

Closing this request for now. Feel free to reopen after a rebase, or submit a new request.

@dv-anomaly dv-anomaly closed this Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-pass encoding
2 participants
@ardeaf @dv-anomaly