Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement paging for peers/channels #19

Open
prusnak opened this issue Jan 14, 2019 · 7 comments
Open

Implement paging for peers/channels #19

prusnak opened this issue Jan 14, 2019 · 7 comments

Comments

@prusnak
Copy link
Collaborator

prusnak commented Jan 14, 2019

Our node has 500+ channels and it takes quite some time to load the "Channels" page. It makes sense to implement some paging.

@djmelik
Copy link
Owner

djmelik commented Jan 15, 2019

Good idea. We should also add a search bar with a drop down so that we can select/view an individual peer.

@prusnak prusnak changed the title Implement paging for channels Implement paging for peers/channels Jan 18, 2019
@prusnak
Copy link
Collaborator Author

prusnak commented Jan 18, 2019

There is a module for this: https://flask-paginate.readthedocs.io/

Maybe it is an overkill and something similar to this is more than enough: http://flask.pocoo.org/snippets/44/

@juscamarena
Copy link

Great, mine just times out using it with the bitrefill node.

[2019-01-26 04:05:49 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:371)
[2019-01-26 04:05:49 +0000] [371] [INFO] Worker exiting (pid: 371)
[2019-01-26 04:05:49 +0000] [558] [INFO] Booting worker with pid: 558
[2019-01-26 04:06:20 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:558)
[2019-01-26 04:06:20 +0000] [558] [INFO] Worker exiting (pid: 558)
[2019-01-26 04:06:20 +0000] [742] [INFO] Booting worker with pid: 742
[2019-01-26 04:07:17 +0000] [1] [CRITICAL] WORKER TIMEOUT (pid:742)
[2019-01-26 04:07:17 +0000] [742] [INFO] Worker exiting (pid: 742)
[2019-01-26 04:07:17 +0000] [918] [INFO] Booting worker with pid: 918

@djmelik
Copy link
Owner

djmelik commented Jan 26, 2019

How about something like this instead? A lighter table view of all of the channels, we can also add some javascript to the table allowing us to sort/filter the rows. The idea would be to click/select an individual channel to bring up a more detailed view ie. /channels/<chan_id>.

I can push my local branch tomorrow when I'm done for you guys to test/evaluate.

screen shot 2019-01-26 at 3 02 22 am

@djmelik
Copy link
Owner

djmelik commented Jan 26, 2019

Example of filtered/sorted table:
screen shot 2019-01-26 at 3 32 42 am

@21isenough
Copy link
Contributor

This looks awesome. Can you push a branch with these adjustments? Would love to try that out.

@juscamarena
Copy link

Awesome, would test it out here as well, /channels doesn't load at me at all, but I'm running it remotely with a node with 420+ channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants