Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO3 12 compatibility #304

Open
svewap opened this issue Jan 18, 2023 · 23 comments · May be fixed by #323
Open

TYPO3 12 compatibility #304

svewap opened this issue Jan 18, 2023 · 23 comments · May be fixed by #323

Comments

@svewap
Copy link

svewap commented Jan 18, 2023

Here is my version for T3 12: https://github.com/svewap/extension-cookieman/tree/12-svewap
I can make a pull request if you want.

@jonaseberle
Copy link
Member

Thanks Sven!
Yes, please open a PR :)
I have branched off 11lts so we can work on v12 together.

There is #271 which needs to be solved.

I am planning to work next week on it.

@weisgerberm
Copy link

Hi, any Updates for v12 support? Thank you

@zenoussi
Copy link

zenoussi commented May 5, 2023

Hi, any Updates for v12 support? Thank you

Same question. Thanks

@svewap
Copy link
Author

svewap commented May 8, 2023

I opened a PR

@ingeniumdesign
Copy link

new Infos?

@jonaseberle
Copy link
Member

Sorry, not much yet.

You can use #311 which works very well.

What's holding me back is that I would like to have a good solution for #271 because v12 (or rather typo3/cms-composer-installers:^5) changes the paths of public assets. Most users will not hit that problem (of including files in inject()) and there are ways to work around it.

@msollmann
Copy link

Overriding of labels via _LOCAL_LANG isn't working anymore. Do we have to use locallangXMLOverride instead?

@jonaseberle
Copy link
Member

@msollmann You mean in the T3 v12 branch?

@msollmann
Copy link

In #311.

In addition I can only override my own labels (e.g. "group.externalServices"), not existing labels (e.g. "group.marketing") via locallangXMLOverride.

@ingeniumdesign
Copy link

new Infos?

@Finulin
Copy link

Finulin commented Oct 24, 2023

release for TYPO3 v12 would be nice

@jonaseberle
Copy link
Member

Yes, I agree, but I have not found the time. It would really help if you could test #311 and leave feedback there.

If someone would like to dive into the docs and adjust the examples where needed, that would help as well.

@jonaseberle jonaseberle linked a pull request Nov 3, 2023 that will close this issue
9 tasks
@jonaseberle
Copy link
Member

@msollmann your translation problem is https://forge.typo3.org/issues/100759

@ingeniumdesign
Copy link

Maybe as a christmas present? :)

@jonaseberle
Copy link
Member

@ingeniumdesign yes, thank you, please go ahead and test #323 ;)
composer req dmind/cookieman:dev-dev/12lts.

@ingeniumdesign
Copy link

The installation worked fine, the output works fine, now I'll test the settings a bit more

@jonaseberle
Copy link
Member

The _LOCAL_LANG TypoScript issue should be solved in TYPO3 v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023.

jonaseberle added a commit that referenced this issue Jan 22, 2024
_LOCAL_LANG l10n overrides/extensions stopped working in non-Extbase contexts
 That was fixed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023 which
was released with TYPO3 v12.4.9.

Relates: #304
@ingeniumdesign
Copy link

yes, the _LOCAL_LANG TypoScript issue dont work. New Infos?

@jonaseberle
Copy link
Member

@ingeniumdesign Are you adding the extensionName in translations like this? {f:translate(key: 'heading', extensionName: 'cookieman')}

@jankornblum
Copy link

For me everything works fine with 12 lts. When will you publish official version? I have many projects waiting to get upgraded to 12 lts, where cookieman is the only blocker :(

@jonaseberle
Copy link
Member

I am sorry. The docs are still not ready #323.

You can pin the latest commit with composer req dmind/cookieman:dev-dev/12lts#cc9364f4ba76de706f4af2a3e1be7372aaabba09.

@jankornblum
Copy link

Thanks, yes, but I don't like to require a dev-branch in a live project so much ;)

@jonaseberle
Copy link
Member

You would pin a commit that you have tested. But ok, I understand what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants