-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 LTS #323
Open
jonaseberle
wants to merge
49
commits into
master
Choose a base branch
from
dev/12lts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
12 LTS #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The _LOCAL_LANG TypoScript issue should be solved in TYPO3 v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023. |
_LOCAL_LANG l10n overrides/extensions stopped working in non-Extbase contexts That was fixed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023 which was released with TYPO3 v12.4.9. Relates: #304
jonaseberle
force-pushed
the
dev/12lts
branch
2 times, most recently
from
February 6, 2024 19:07
105f7bf
to
fbfa0ee
Compare
jonaseberle
force-pushed
the
dev/12lts
branch
from
February 6, 2024 19:08
fbfa0ee
to
923bf1f
Compare
👍 Works like a charm. Would be great to get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of rebased #311.
Necessary changes:
inject ()
Asset paths in TypoScript
_asset paths in TypoScript can be added with
(mind the leading
/
!)but this has shortcomings (see https://forge.typo3.org/issues/99203#change-507069). For v13 we'll get the
{asset : ...}
getText (https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018).f:translate in non-Extbase contexts
Due to a probable requirement for
extensionName
in each{f:translate}
instance (forge issue: https://forge.typo3.org/issues/102315) it is very probable that custom templates will break. That would warrant a major (breaking) release for cookieman.Translations in TypoScript (solved in TYPO3 Core v12.4.9+)
Adding translations with
plugin.*._LOCAL_LANG
in page layout context did also not work anymore in TYPO3v12 (https://forge.typo3.org/issues/100759) - (This is solved for v12.4.9+ by https://review.typo3.org/c/Packages/TYPO3.CMS/+/82023)We might have to recommend this instead:
How to use this:
composer req dmind/cookieman:dev-dev/12lts
(or, pin a commit when using it in production: for exampledmind/cookieman:dev-dev/12lts#cc9364f4ba76de706f4af2a3e1be7372aaabba09
)– please test and give feedback
Fixes: #304
Fixes: #271