Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring of encryption commands #18

Open
fizzyade opened this issue May 21, 2020 · 1 comment
Open

refactoring of encryption commands #18

fizzyade opened this issue May 21, 2020 · 1 comment

Comments

@fizzyade
Copy link

I think it makes sense to refactor the encryption, currently the software uses aes_init aes_encrypt etc as function names regardless of whether aes encryption is used, it might actually be blowfish or something else that is actually being used.

Something like the following might give the code a bit more clarity:

eal_init
eal_encrypt
eal_decrypt

(Encryption Abstraction Layer)

It's just a thought and something that's been bugging me in the back of my mind for months, the whole project is very well written and this "misnaming" (probably for historical reasons) just doesn't seem in keeping with your own high standards.

I know it's a minor thing and it makes no difference to functionality, but I personally think it will bring an improvement to the code base.

@dmitrystu
Copy link
Owner

BTW. AES is not an actual name of the cipher. It is Rijndael.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants