You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it makes sense to refactor the encryption, currently the software uses aes_init aes_encrypt etc as function names regardless of whether aes encryption is used, it might actually be blowfish or something else that is actually being used.
Something like the following might give the code a bit more clarity:
eal_init
eal_encrypt
eal_decrypt
(Encryption Abstraction Layer)
It's just a thought and something that's been bugging me in the back of my mind for months, the whole project is very well written and this "misnaming" (probably for historical reasons) just doesn't seem in keeping with your own high standards.
I know it's a minor thing and it makes no difference to functionality, but I personally think it will bring an improvement to the code base.
The text was updated successfully, but these errors were encountered:
I think it makes sense to refactor the encryption, currently the software uses aes_init aes_encrypt etc as function names regardless of whether aes encryption is used, it might actually be blowfish or something else that is actually being used.
Something like the following might give the code a bit more clarity:
eal_init
eal_encrypt
eal_decrypt
(Encryption Abstraction Layer)
It's just a thought and something that's been bugging me in the back of my mind for months, the whole project is very well written and this "misnaming" (probably for historical reasons) just doesn't seem in keeping with your own high standards.
I know it's a minor thing and it makes no difference to functionality, but I personally think it will bring an improvement to the code base.
The text was updated successfully, but these errors were encountered: