Fix CLang compiler errors

Author: dmrokan

.github/workflows/builds.yml

@@ -93,6 +93,13 @@ jobs:
           ./bootstrap.sh
           ./b2 headers
         working-directory: boost
+      - name: Bootstrap patches
+        shell: sh
+        run: |
+          patch -s -p0 < read.patch
+          patch -s -p0 < polygon_45_set_data.patch
+          patch -s -p0 < rational.patch
+          patch -s -p0 < boolean_op_45.patch
       - name: Compile godot-cpp
         shell: sh
         run: |

boolean_op_45.patch

@@ -0,0 +1,10 @@
+--- boost/libs/polygon/include/boost/polygon/detail/boolean_op_45.hpp	2024-07-31 23:46:08.633941157 +0300
++++ boost/libs/polygon/include/boost/polygon/detail/boolean_op_45.hpp.modified	2024-07-31 23:36:42.118430273 +0300
+@@ -816,7 +816,6 @@
+             //the cross point is not on the integer grid and cannot be represented
+             //we must throw an exception
+             std::string msg = "GTL 45 Boolean error, precision insufficient to represent edge intersection coordinate value.";
+-            throw(msg);
+           } else {
+             //note that result of this subtraction is always positive because itr1 is above itr2 in scanline
+             LongUnit halfDelta2 = (LongUnit)((((LongUnit)y1) - y2)/2);

polygon_45_set_data.patch

@@ -0,0 +1,46 @@
+--- boost/libs/polygon/include/boost/polygon/polygon_45_set_data.hpp	2024-07-31 23:49:08.016048498 +0300
++++ boost/libs/polygon/include/boost/polygon/polygon_45_set_data.hpp.modified	2024-07-31 23:36:20.069293631 +0300
+@@ -1578,9 +1578,10 @@
+     } else {
+       sort();
+       rvalue.sort();
+-      try {
++      if constexpr (true) {
+         result.is_manhattan_ = applyBoolean45OpOnVectors<Unit, op>(result.data_, data_, rvalue.data_);
+-      } catch (std::string str) {
++      } else {
++        std::string str;
+         std::string msg = "GTL 45 Boolean error, precision insufficient to represent edge intersection coordinate value.";
+         if(str == msg) {
+           result.clear();
+@@ -1659,7 +1660,7 @@
+           result.is_manhattan_ = result_is_manhattan;
+           result.dirty_ = false;
+           result.unsorted_ = false;
+-        } else { throw str; }
++        } else { }
+       }
+       //std::cout << "DONE SCANNING\n";
+     }
+@@ -1699,9 +1700,10 @@
+       result.unsorted_ = false;
+     } else {
+       sort();
+-      try {
++      if constexpr (true) {
+         result.is_manhattan_ = applyUnary45OpOnVectors<Unit, op>(result.data_, data_);
+-      } catch (std::string str) {
++      } else {
++        std::string str;
+         std::string msg = "GTL 45 Boolean error, precision insufficient to represent edge intersection coordinate value.";
+         if(str == msg) {
+           result.clear();
+@@ -1770,7 +1772,7 @@
+           result.is_manhattan_ = result_is_manhattan;
+           result.dirty_ = false;
+           result.unsorted_ = false;
+-        } else { throw str; }
++        } else { }
+       }
+       //std::cout << "DONE SCANNING\n";
+     }

rational.patch

@@ -0,0 +1,24 @@
+--- boost/libs/rational/include/boost/rational.hpp	2024-07-31 23:49:25.025152763 +0300
++++ boost/libs/rational/include/boost/rational.hpp.modified	2024-07-31 23:53:04.925500721 +0300
+@@ -946,15 +946,15 @@
+             if ( c == '/' )
+             {
+                 if ( is >> std::noskipws >> d )
+-                    try {
++                  { if constexpr (true) {
+                         r.assign( n, d );
+-                    } catch ( bad_rational & ) {        // normalization fail
+-                        try { is.setstate(ios::failbit); }
+-                        catch ( ... ) {}  // don't throw ios_base::failure...
++                    } else {        // normalization fail
++                      if (true) { is.setstate(ios::failbit); }
++                        else {}  // don't throw ios_base::failure...
+                         if ( is.exceptions() & ios::failbit )
+-                            throw;   // ...but the original exception instead
++                          (void) 0;   // ...but the original exception instead
+                         // ELSE: suppress the exception, use just error flags
+-                    }
++                    } }
+             }
+             else
+                 is.setstate( ios::failbit );

read.patch

@@ -0,0 +1,29 @@
+--- boost/libs/geometry/include/boost/geometry/io/wkt/read.hpp	2024-07-31 23:49:44.507272188 +0300
++++ boost/libs/geometry/include/boost/geometry/io/wkt/read.hpp.modified	2024-07-31 23:37:17.314648387 +0300
+@@ -137,7 +137,6 @@
+         // Stop at end of tokens, or at "," ot ")"
+         bool finished = (it == end || *it == "," || *it == ")");
+ 
+-        try
+         {
+             // Initialize missing coordinates to default constructor (zero)
+             // OR
+@@ -149,18 +148,6 @@
+                     ? coordinate_type()
+                     : coordinate_cast<coordinate_type>::apply(*it));
+         }
+-        catch(boost::bad_lexical_cast const& blc)
+-        {
+-            BOOST_THROW_EXCEPTION(read_wkt_exception(blc.what(), it, end, wkt));
+-        }
+-        catch(std::exception const& e)
+-        {
+-            BOOST_THROW_EXCEPTION(read_wkt_exception(e.what(), it, end, wkt));
+-        }
+-        catch(...)
+-        {
+-            BOOST_THROW_EXCEPTION(read_wkt_exception("", it, end, wkt));
+-        }
+ 
+         parsing_assigner<Point, Dimension + 1, DimensionCount>::apply(
+                         (finished ? it : ++it), end, point, wkt);