DNN SMTP Test Settings

[thabaum]

From this point in my history there was two contributors to the file:

                var mailFrom = Host.HostEmail;
                var mailTo = smtpHostMode ? Host.HostEmail : PortalSettings.UserInfo.Email;

Then I contributed this patch:

var mailFrom = smtpHostMode ? Host.HostEmail : PortalSettings.Email;              
var mailTo = UserInfo.Email;

3870357

But recent version shows this

Still contains the logic I contributed however this. has been added.

                var mailFrom = smtpHostMode ? Host.HostEmail : this.PortalSettings.Email;
                var mailTo = this.UserInfo.Email;

I am trying to chase some issues in the smtp not using the portal admin email on a portal but seems to work fine on other portals I believe... I was trying to go back through the code and changes... it seems my name has been removed from this file as a contributor, so I am asking how and why? Was there a regression? It looks like same code logic I contributed just no credit, I was wondering how I disappeared from the file.

#3237

[bdukes]

I think it probably got lost in a merge. Since it's just a one-line change, when someone else touched that line (to adjust styles and add this.), you were no longer an "owner" of that line change. It is weird that GitHub still doesn't show you as a contributor, but I guess it figures that figuring out contributors line-by-line is usually good enough (and prevents old contributors from showing up, for good or bad).

[thabaum]

OK, I was just curious I figured that the this addition would probably have done it.