-
|
Looking at the SMTP controllers and noticed old things needing to get replaced with the new.
I was trying to utilize some of what it recommends. I am wondering how I may be able to help cleanup some of these things. I know @ahoefling had recommended treating the warnings as errors. Wouldn't this be one of them here? And if so I wish to learn how I can help resolve these issues for the platform. |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 6 replies
-
|
@thabaum one thing to be aware of with SMTP specifically is that there's a pending pull request #3969 to adjust a lot of that code and move it into a provider. So I check to make sure whatever you're working with isn't about to be changed anyway (you should be good to adjust the Persona Bar pieces, but the core pieces will be shifting around). |
Beta Was this translation helpful? Give feedback.
-
|
This was just an example, I am aware of the SMTP changes. I was not going to work on this until I get a full understanding of any new changes going into 10. I am warming up for 10 being busy with this type of work replacing things... |
Beta Was this translation helpful? Give feedback.
-
|
For these deprecations where we're moving from public class ServerSettingsSmtpHostController : PersonaBarApiController
{
private readonly IHostSettingsService hostSettingsService;
public ServerSettingsSmtpHostController(IHostSettingsService hostSettingsService)
{
this.hostSettingsService = hostSettingsService;
}
}You can then replace |
Beta Was this translation helpful? Give feedback.
-
|
@bdukes you beat me to it, this is exactly what I was going to recommend. Many of these deprecations require the usage of Dependency Injection. @thabaum if you are working in an area of DNN that does not support Dependency Injection I urge you to create an issue on the backlog and document where we need to add it in DNN. The goal is to make Dependency Injection accessible in every part of the platform where possible. We are currently a long way off from that goal, but the more people documenting the lack of the support the more likely we can get it done faster 💯 |
Beta Was this translation helpful? Give feedback.
-
|
Great thanks, I think that clears it up a lot. These marked for obsolete I presume they all have the I will give it a go in an area that is not worked on much first... |
Beta Was this translation helpful? Give feedback.
-
|
Yes. I also want to note that with that specific deprecation, some of those messages point to the wrong type (it got renamed after those messages were started, fix is #4092) |
Beta Was this translation helpful? Give feedback.
-
|
There is a lot of work happening in Dependency Injection space right now and as we move more and more core components to the abstractions library we are finding better conventions to follow. We are doing our best to keep the deprecation notices up-to-date. If you find anything that seems out of place, I encourage you to start a discussion and we can then decide if we need to create an item on the backlog to fix it. |
Beta Was this translation helpful? Give feedback.
-
|
I will help when I can as this helps make things much clearer what is happening currently behind the scenes in DNN with respect to DI. Thank you @bdukes and @ahoefling for getting me up to speed. I will watch future related PR's and dig into a few of the past to help connect the dots further. If you have a great example of of a PR adding DI where needed please share I would love reviewing it! |
Beta Was this translation helpful? Give feedback.
-
|
You can take a look at the PRs I have been submitting recently
Those are all completed PRs, there is a lot of dependency injection work going on right now so plenty of examples to share. |
Beta Was this translation helpful? Give feedback.
For these deprecations where we're moving from
Whatever.InstancetoIWhatever, to resolve the warning you need to start retrieving the interface via dependency injection. Exactly how you do that will depend a lot on which part of the code you're in. If you're looking at a Web API controller (e.g. in the Persona Bar code), you can just add an additional constructor dependency and DI will fill it in automatically. For instance,