Optimizations

Author: lsegal

app/controllers/gems_controller.rb

@@ -6,7 +6,8 @@ class GemsController < ApplicationController
 
   prepend_before_action do
     @title = "RubyGems"
-    @collection = Library.allowed_gem.all
+    # Select only needed columns to reduce memory usage
+    @collection = Library.allowed_gem.select(:id, :name, :source, :owner, :versions)
   end
 
   def index

app/controllers/github_controller.rb

@@ -8,7 +8,8 @@ class GithubController < ApplicationController
 
   prepend_before_action do
     @title = "GitHub Projects"
-    @collection = Library.allowed_github.all
+    # Select only needed columns to reduce memory usage
+    @collection = Library.allowed_github.select(:id, :name, :source, :owner, :versions, :updated_at)
   end
 
   def index

app/helpers/application_helper.rb

@@ -81,9 +81,16 @@ def has_featured?
   end
 
   def featured_libraries
-    Rubydoc.config.libraries[:featured].map do |name, source|
+    featured_config = Rubydoc.config.libraries[:featured]
+    return [] if featured_config.blank?
+
+    # Batch load all gem libraries in one query to avoid N+1
+    gem_names = featured_config.select { |_, source| source == "gem" }.keys
+    gem_libraries = Library.gem.where(name: gem_names).index_by(&:name)
+
+    featured_config.map do |name, source|
       if source == "gem"
-        Library.gem.find_by(name: name)
+        gem_libraries[name]
       elsif source == "featured"
         versions = FeaturedLibrary.versions_for(name)
         Library.new(name: name, source: :featured, versions: versions)

app/jobs/update_remote_gems_list_job.rb

@@ -23,18 +23,21 @@ def perform
     logger.info "Updating remote RubyGems..."
 
     inserts = []
-    changed_gems = Library.gem.all.map { |lib| [ lib.name, lib ] }.to_h
-    removed_gems = changed_gems.keys
+    # Use pluck + index to reduce memory usage instead of loading full AR objects
+    changed_gems = Library.gem.pluck(:name, :id, :versions).each_with_object({}) do |(name, id, versions), hash|
+      hash[name] = { id: id, versions: versions }
+    end
+    removed_gems = changed_gems.keys.to_set
 
     fetch_remote_gems.each do |name, versions|
       versions = pick_best_versions(versions)
-      lib = changed_gems[name]
+      lib_data = changed_gems[name]
 
-      if lib
+      if lib_data
         removed_gems.delete(name)
 
-        if lib.versions != versions
-          lib.update(versions: versions)
+        if lib_data[:versions] != versions
+          Library.where(id: lib_data[:id]).update_all(versions: versions)
         else
           changed_gems.delete(name)
         end
@@ -53,8 +56,8 @@ def perform
     end
 
     if removed_gems.size > 0
-      Library.delete_by(name: removed_gems)
-      logger.info "Removed #{removed_gems.size} gems: #{removed_gems.join(', ')}"
+      Library.where(source: :remote_gem, name: removed_gems.to_a).delete_all
+      logger.info "Removed #{removed_gems.size} gems: #{removed_gems.to_a.join(', ')}"
     end
   ensure
     self.class.clear_lock_file if @can_clear_lock_file
@@ -96,8 +99,9 @@ def flush_cache(gem_names)
     end
     CacheClearJob.perform_later("/gems", "/featured", *index_map.keys.map { |k| "/gems/~#{k}" })
 
-    gem_names.each_slice(50) do |list|
-      CacheClearJob.perform_later(*list.map { |k| [ "/gems/#{k}/", "/list/gems/#{k}/", "/static/gems/#{k}" ] }.flatten)
+    # Batch into larger chunks to reduce job overhead
+    gem_names.each_slice(100) do |list|
+      CacheClearJob.perform_later(*list.flat_map { |k| [ "/gems/#{k}/", "/list/gems/#{k}/", "/static/gems/#{k}" ] })
     end
   end
 end

app/models/library.rb

@@ -20,14 +20,16 @@ def self.wildcard(list)
   end
 
   def library_versions
-    items = versions.map do |v|
-      ver, platform = *v.split(",")
-      lib = YARD::Server::LibraryVersion.new(name, ver, nil, source)
-      lib.platform = platform
-      lib
-    end
+    @library_versions ||= begin
+      items = versions.map do |v|
+        ver, platform = *v.split(",")
+        lib = YARD::Server::LibraryVersion.new(name, ver, nil, source)
+        lib.platform = platform
+        lib
+      end
 
-    source == :github ? sorted_github_library_versions(items) : items
+      source == :github ? sorted_github_library_versions(items) : items
+    end
   end
 
   def name

app/views/shared/library_list.html.erb

@@ -20,7 +20,7 @@
   <h3>All matches</h3>
 <% end %>
 <div class="libraries">
-  <% if @collection.count == 0 %>
+  <% if @collection.empty? %>
     <div class="row">No matches found.</div>
   <% end %>
   <%= render partial: "shared/library", collection: @collection %>

db/migrate/20251201000001_add_lower_name_index_to_libraries.rb

@@ -0,0 +1,7 @@
+class AddLowerNameIndexToLibraries < ActiveRecord::Migration[8.0]
+  def change
+    # Add a functional index for efficient alphabetical filtering
+    # This improves the LIKE 'a%' queries used in AlphaIndexable concern
+    add_index :libraries, "lower(name) varchar_pattern_ops", name: "index_libraries_on_lower_name_pattern"
+  end
+end