Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor can't be reused twice #1899

Open
1 task done
scruel opened this issue Sep 27, 2022 · 3 comments · May be fixed by #1904
Open
1 task done

Anchor can't be reused twice #1899

scruel opened this issue Sep 27, 2022 · 3 comments · May be fixed by #1904
Labels
enhancement

Comments

@scruel
Copy link

scruel commented Sep 27, 2022

Bug Report

Steps to reproduce

  1. Click the anchor (url will be URL1 now)
  2. Scroll to the anchor
  3. Click the anchor again

Or visit URL1, repeat step 2 and 3.

What is current behaviour

Second click on the anchor won't work.

What is the expected behaviour

Second click on the anchor should still jump to the right position

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: windows10

  • Browser version: Firefox 105

  • Docsify version: 4.12.2

  • Docsify plugins: None

Please create a reproducible sandbox

Edit

Mention the docsify version in which this bug was not present (if any)
@Koooooo-7
Copy link
Member

Hi @scruel , could plz provide a gif or something reproduce it in sandbox? I opened the sandbox but not quite sure what the issue is.

@scruel
Copy link
Author

scruel commented Oct 7, 2022

Hi @scruel , could plz provide a gif or something reproduce it in sandbox? I opened the sandbox but not quite sure what the issue is.

  1. visit https://docsify.js.org/#/plugins?id=full-text-search
  2. scroll down to the bottom
  3. click "Full Text Search"

Excepted jump to the "Full Text Search" section, but nothing happened.
image

@Koooooo-7
Copy link
Member

Koooooo-7 commented Oct 7, 2022 •
edited
Loading

Hi @scruel I see, cos it does not trigger the hashchange event to make this content scroll, i.e. click another selection and click it back, it should work as expected. Gonna have a fix on it.

@Koooooo-7 Koooooo-7 linked a pull request Oct 7, 2022 that will close this issue
Draft
9 tasks
@fabiogatti fabiogatti mentioned this issue Nov 4, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update: enhance the navigating. docsifyjs/docsify
2 participants
@scruel @Koooooo-7