Skip to content

Commit a90ee5c

Browse files
committed
Merge branch '2.19.x' into 3.1.x
* 2.19.x: Test with actual lock modes (#11465) Backport test for Query::setLockMode() (#11463)
2 parents 1127042 + 552eae3 commit a90ee5c

File tree

1 file changed

+15
-6
lines changed

1 file changed

+15
-6
lines changed

tests/Tests/ORM/Cache/Persister/Entity/EntityPersisterTestCase.php

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use Doctrine\Common\Collections\ArrayCollection;
88
use Doctrine\Common\Collections\Criteria;
9+
use Doctrine\DBAL\LockMode;
910
use Doctrine\ORM\Cache\Persister\CachedPersister;
1011
use Doctrine\ORM\Cache\Persister\Entity\AbstractEntityPersister;
1112
use Doctrine\ORM\Cache\Persister\Entity\CachedEntityPersister;
@@ -97,7 +98,7 @@ public function testInvokeGetSelectSQL(): void
9798
->with(
9899
self::identicalTo(['name' => 'Foo']),
99100
self::identicalTo($associationMapping),
100-
self::identicalTo(1),
101+
self::identicalTo(LockMode::OPTIMISTIC),
101102
self::identicalTo(2),
102103
self::identicalTo(3),
103104
self::identicalTo([4]),
@@ -107,7 +108,7 @@ public function testInvokeGetSelectSQL(): void
107108
self::assertSame('SELECT * FROM foo WERE name = ?', $persister->getSelectSQL(
108109
['name' => 'Foo'],
109110
$associationMapping,
110-
1,
111+
LockMode::OPTIMISTIC,
111112
2,
112113
3,
113114
[4],
@@ -233,13 +234,21 @@ public function testInvokeLoad(): void
233234
self::identicalTo($entity),
234235
self::identicalTo($associationMapping),
235236
self::identicalTo([1]),
236-
self::identicalTo(2),
237+
self::identicalTo(LockMode::PESSIMISTIC_READ),
237238
self::identicalTo(3),
238239
self::identicalTo([4]),
239240
)
240241
->willReturn($entity);
241242

242-
self::assertSame($entity, $persister->load(['id' => 1], $entity, $associationMapping, [1], 2, 3, [4]));
243+
self::assertSame($entity, $persister->load(
244+
['id' => 1],
245+
$entity,
246+
$associationMapping,
247+
[1],
248+
LockMode::PESSIMISTIC_READ,
249+
3,
250+
[4],
251+
));
243252
}
244253

245254
public function testInvokeLoadAll(): void
@@ -402,9 +411,9 @@ public function testInvokeLock(): void
402411

403412
$this->entityPersister->expects(self::once())
404413
->method('lock')
405-
->with(self::identicalTo($identifier), self::identicalTo(1));
414+
->with(self::identicalTo($identifier), self::identicalTo(LockMode::OPTIMISTIC));
406415

407-
$persister->lock($identifier, 1);
416+
$persister->lock($identifier, LockMode::OPTIMISTIC);
408417
}
409418

410419
public function testInvokeExists(): void

0 commit comments

Comments
 (0)