Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

lang.mixin errors with null target #409

Open
odoe opened this issue Jun 13, 2018 · 0 comments
Open

lang.mixin errors with null target #409

odoe opened this issue Jun 13, 2018 · 0 comments

Comments

@odoe
Copy link
Contributor

odoe commented Jun 13, 2018

Enhancement

Currently, it doesn't look like @dojo/core/lang#mixin handles null targets.
I don't think a user would intentionally pass undefined or null, but I ran across this when transitioning from Dojo 1 to Dojo 2. The Dojo 1 mixin method does handles this use case.

Maybe this expected behavior and users of mixin should handle this on a case by case basis, but felt I should bring it up anyway.

Package Version: 2.0.0

const obj = mixin(undefined, { age: 40 });

https://codesandbox.io/s/zwovr308jx - Dojo 2
http://jsbin.com/bufiyi/2/edit?html,js,console - Dojo 1

Expected behavior:

const obj = mixin(undefined, { age: 40 }); // { age: 40 }

Actual behavior:

const obj = mixin(undefined, { age: 40 }); //Type Error Cannot set property 'name' of null

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant