Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dojox/dtl/_Templated does not work any more with widgets in template #327

Open
edurocher opened this issue Nov 24, 2020 · 0 comments
Open

dojox/dtl/_Templated does not work any more with widgets in template #327

edurocher opened this issue Nov 24, 2020 · 0 comments

Comments

@edurocher
Copy link

We have upgraded from 1.10 to 1.16 and noticed that some of our widgets using dojox/dtl/_Templated did not work any more because the sub-widgets contained in the template were not created.

Investigating a little more, it appears to be caused by this commit in dijit that removes the widgetsInTemplate flag. This flag is still expected by dojox/dtl/_Templated to decide to parse sub-widgets, though.

Our workaround is to add the flag explicitly in our widgets. Everything seems to work fine then.

I don't know if there is enough interest to fix this in dtl, but a cleaner solution would be to do the same detection in dtl as in dijit to know if there are any widgets in the template.
edurocher referenced this issue in dojo/dijit Nov 24, 2020
@wkeese
Remove widgetsInTemplate property and instead auto-detect
4aa5ea0 
whether or not template contains widgets.

Fixes #18768.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edurocher