Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swashbuckle.AspNetCore.Newtonsoft for net6.0 depends on the first release candidate instead of the actual 6.0 release. #2471

Closed
prvyk opened this issue Jul 29, 2022 · 3 comments

Comments

@prvyk
Copy link

prvyk commented Jul 29, 2022

The default dependency for the Swashbuckle.AspNetCore.Newtonsoft package on net6.0 is Microsoft.AspNetCore.Mvc.NewtonsoftJson 6.0.0-rc.1.21452.15 . Net6.0 has been out since last year. I don't think there are any significant changes to Microsoft.AspNetCore.Mvc.NewtonsoftJson between that and release, but it's good practice to depend on the actual release. It was enough to make my hair stand on end ("Why are we depending on a prerelease?")..

https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.Newtonsoft/Swashbuckle.AspNetCore.Newtonsoft.csproj#L28

@Andrioden
Copy link

Any news here?

Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further updates are made.

@github-actions github-actions bot added the stale Stale issues or pull requests label Apr 19, 2024
@martincostello martincostello removed the stale Stale issues or pull requests label Apr 19, 2024
@martincostello
Copy link
Collaborator

Resolved by #2775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants