Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

"error" not emitted on incomplete JSON #112

Open
robaca opened this issue Nov 16, 2016 · 4 comments
Open

"error" not emitted on incomplete JSON #112

robaca opened this issue Nov 16, 2016 · 4 comments

Comments

@robaca
Copy link

robaca commented Nov 16, 2016

If I pass JSON that is incomplete, like

{"rows":[{"id":"id-1","name":"Name A"},{"id":"id-2","name":"

to the parser, it doesn't emit an error.

robaca added a commit to codecentric/JSONStream that referenced this issue Dec 22, 2016
@lojzatran
Copy link

Hi, what's the status of this task? I saw there's PR already, when it will be merged? Thanks!

@dominictarr
Copy link
Owner

@lojzatran the pull request is incorrect, see my comments on it

@dumbmatter
Copy link

Seems there have been some commits since your last comment on that PR. Are there any other outstanding issues with the PR? If anything needs to be done (like putting this new behavior behind an option to maintain backwards compatibility), I'd be happy to help.

I have to work with some APIs that output JSON but sometimes fail by terminating early, and I would like to handle that error case rather than silently continue to work with partial data. Probably at least a few other sad people have to deal with similar APIs :)

@vancouverwill
Copy link

this would be very useful!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants