Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ROG Strix SCAR II #4

Closed
shyrma opened this issue Aug 29, 2019 · 9 comments
Closed

Add support for ROG Strix SCAR II #4

shyrma opened this issue Aug 29, 2019 · 9 comments
Assignees
Labels
add new device Add support for new device set but not get Unable to get previously set temperatures

Comments

@shyrma
Copy link

shyrma commented Aug 29, 2019

Environment
asus-fan-control version: 2.8.1
OS: Linux Mint 19.2 Cinnamon
Linux Kernel: 4.15.0-58-generic
Processor: Intel© Core™ i7-8750H CPU @ 2.20GHz × 6
Graphics: Intel Corporation Device 3e9b, Intel driver: i915 v: kernel
GeForce RTX 2070/PCIe/SSE2 v: 4.6.0 NVIDIA 430.26n.

Temperature configuration
55 56 57 58 59 60 61 62

Notebook model name
Strix GL704GW_GL704GW

Hi dominiksalvet

First of all thanks a lot for development of this program!

Looks like asus-fan-control has no affect on my fans.
I have following output in console

yurii@yurii-laptop:$ sudo gitpack install github.com/dominiksalvet/asus-fan-control=master
[install] github.com/dominiksalvet/asus-fan-control d311ed4

yurii@yurii-laptop:$ sudo asus-fan-control -get-temps
55 56 57 58 59 60 61 62

yurii@yurii-laptop:$ sudo asus-fan-control -set-temps:'55 57 59 61 63 65 67 69'

yurii@yurii-laptop:$ sudo asus-fan-control -get-temps
55 56 57 58 59 60 61 62

As you may note applying -set-temps has no affect since -get-temps shows other (default) numbers. Also default numbers are not working as well, because (if I understand correctly) fans should be off when temperature is < 55, but I can totally hear fan noise even if temperature is < 50.

@shyrma shyrma added the add new device Add support for new device label Aug 29, 2019
@dominiksalvet
Copy link
Owner

@shyrma Hi and thank you for your kind words! ❤️ But unfortunately, it seems that I can't help you with that issue... 😞

The program should work even with untested models as long as they have the same ACPI addresses for the fan configuration, it only uses the default temperatures. In this particular case, it looks like ASUS has changed the addresses, or maybe there is a problem related to two-fan model if applicable. As you pointed out, it really looks like the program has zero effect on your machine. Since you are testing a new model, it is certainly better than unexpected shutdown or so...

For the sake of completeness, reboot your device and try to run the sudo asus-fan-control commands mentioned and print also their return values. You can do it by executing echo "$?" right after each command.

I am really sorry but I created this project for my own machine and the fact it works on other models was just coincidence, so I added only a basic mechanism to support multiple models. Now, I keep it maintaining only for purposes of GitPack and in case that someone will find out that it works on its untested model without any work, in which case we would try to find the best temperature configuration and add it as an official tested model and the program will recognise it.

But if it does not work for your model at all, I can't help you. I would recommend you to try other projects for fan control. Alternatively, if you like this program so much, have a good knowledge of Unix shell (not Bash) and also have some time, you can add the support for your model yourself. I am open to help. 👍

@shyrma
Copy link
Author

shyrma commented Aug 30, 2019

thanks for information!

Of course I did reboot, there was no effect.
Since I'm not good in Unix shell, looks like I have to take a look on available alternative fan control apps ;-)

@shyrma shyrma closed this as completed Aug 30, 2019
@dominiksalvet
Copy link
Owner

dominiksalvet commented Aug 30, 2019

@shyrma I am really sorry that I can't help you. 😢

You know what? If you will ever work with Unix Shell or any interpreted language and you will need to solve installation, updating and uninstallation of your program by end users, take a look at GitPack. It is as simple as it can be and we can cross our paths once again. Wish you the best! 😄

@shyrma
Copy link
Author

shyrma commented Aug 30, 2019

Ok, I'll take your advise into account ;-)

@dominiksalvet dominiksalvet changed the title seems not working on my laptop Add support for ROG Strix GL704GW Nov 26, 2019
@dominiksalvet
Copy link
Owner

dominiksalvet commented Nov 26, 2019

If anyone is interested in adding support for this model, take a look at this post. It might be helpful as all current supported models are based on it.

Please, let us know in case you find out something important. 🚀

@dominiksalvet dominiksalvet added the help wanted Extra attention is needed label Nov 29, 2019
@dominiksalvet
Copy link
Owner

dominiksalvet commented Nov 29, 2019

I am opening this issue to let other people know that it is not resolved yet and so they can contribute.

@dominiksalvet dominiksalvet reopened this Nov 29, 2019
@dominiksalvet dominiksalvet pinned this issue Nov 29, 2019
@dominiksalvet dominiksalvet unpinned this issue Feb 10, 2020
@dominiksalvet
Copy link
Owner

Hello @shyrma!

I have recently released the 3.0.0 version, which supports different ACPI fan base addresses among tested models. It means that if you know or find the base ACPI address for your model, asus-fan-control will be able to fully support it.

I do not imagine that you know the ACPI base address but just in case. There is hope! 🚀

@dominiksalvet
Copy link
Owner

@shyrma Hopefully the last spam of this kind... But I have good news!

Please have a look at this comment. Maybe it can help! 😃

@dominiksalvet dominiksalvet changed the title Add support for ROG Strix GL704GW Add support for ROG Strix SCAR II Mar 12, 2020
@dominiksalvet dominiksalvet added set but not get Unable to get previously set temperatures and removed help wanted Extra attention is needed labels Jun 19, 2020
@quancore
Copy link

quancore commented Oct 5, 2020

it is the same, not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new device Add support for new device set but not get Unable to get previously set temperatures
Projects
None yet
Development

No branches or pull requests

3 participants