Merge branch 'common'

Author: filipecosta90

.circleci/config.yml

@@ -5,7 +5,7 @@ jobs:
   build:
     docker:
       - image: "debian:stretch"
-    steps:    
+    steps:  
       - run:
           name: Installing SUDO
           command: 'apt update && apt install -y sudo && rm -rf /var/lib/apt/lists/*'
@@ -21,15 +21,21 @@ jobs:
       - run:
           name: Installing CURL
           command: 'apt install -y curl'
+      - run:
+          name: Installing GIT
+          command: 'apt install -y git'
       - checkout
+      - run:
+          name: Pull Submodules
+          command: git submodule update --init --recursive
       - run:
           name: Build & Test
           command: |
             make clean
             make unit_tests
             cd build
-            make test
+            make test ARGS="-V"
             make coverage
-            bash <(curl -s https://codecov.io/bash) -f cmake_coverage.output
+            bash <(curl -s https://codecov.io/bash) -f coverage.info -X gcov -x gcov-7 || echo "Codecov did not collect coverage reports"
 
           

CMakeLists.txt

@@ -57,8 +57,7 @@ add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/src")
 
 # --- Unit Tests ---
 ENABLE_TESTING()
-# Make the output more verbose
-# add_custom_target(test COMMAND ${CMAKE_CTEST_COMMAND} --verbose)
+
 if(BUILD_TESTS)
   add_subdirectory("${CMAKE_CURRENT_SOURCE_DIR}/tests")
 endif(BUILD_TESTS)

README.md

@@ -1,6 +1,6 @@
 
 ![License](https://img.shields.io/badge/License-MIT-blue.svg)
-
+[![codecov](https://codecov.io/gh/filipecosta90/tdigest/branch/master/graph/badge.svg)](https://codecov.io/gh/filipecosta90/tdigest)
 # T-Digest
 
 Adaptive histogram based on something like streaming k-means crossed with Q-digest.

cmake/UseCodeCoverage.cmake

@@ -13,7 +13,7 @@ if(ENABLE_CODECOVERAGE)
     endif ( NOT CMAKE_BUILD_TYPE STREQUAL "Debug" )
 
     if ( NOT DEFINED CODECOV_OUTPUTFILE )
-        set( CODECOV_OUTPUTFILE cmake_coverage.output )
+        set( CODECOV_OUTPUTFILE coverage.info )
     endif ( NOT DEFINED CODECOV_OUTPUTFILE )
 
     if ( NOT DEFINED CODECOV_HTMLOUTPUTDIR )

tests/td_test.c

@@ -185,10 +185,13 @@ MU_TEST(test_nans)
     mu_assert(isnan(td_quantile(t, 0)), "empty value at 0");
     mu_assert(isnan(td_quantile(t, 0.5)), "empty value at .5");
     mu_assert(isnan(td_quantile(t, 1)), "empty value at 1");
+    mu_assert(isnan(td_centroids_weight_at(t,1)), "td_centroids_weight_at on pos > h->merged_nodes");
+    mu_assert(isnan(td_centroids_weight_at(t,-1)), "td_centroids_weight_at on pos < 0");
+    mu_assert(isnan(td_centroids_mean_at(t,1)), "td_centroids_mean_at on pos > h->merged_nodes");
+    mu_assert(isnan(td_centroids_mean_at(t,-1)), "td_centroids_mean_at on pos < 0");
     td_add(t, 1, 1);
     mu_assert(isnan(td_quantile(t, -.1)), "value at -0.1");
     mu_assert(isnan(td_quantile(t, 1.1)), "value at 1.1");
-
     td_free(t);
 }